#195 Add Model Type Attribute #200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bgoelTT
reviewed
Feb 25, 2025
|
|
||
| class ModelTypes(Enum): | ||
| MOCK = "mock" | ||
| CHAT = "chat" |
There was a problem hiding this comment.
Suggested change
| CHAT = "chat" | |
| CHAT = "chat" |
There was a problem hiding this comment.
oops, fixed now. Thanks!
|
This is great @mvanniasingheTT ; as a next step we can work on this issue #204 using the changes in this PR |
bgoelTT
approved these changes
Feb 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #195 (comment) by implementing the feature proposed in #167.
The agent container is now only deployed if the model if of type
CHAT. The code to only remove the agent container when its corresponding LLM container is shut down already exists.