Revert "Refactor conv2d op and add conv2d config support (#2054)" to fix FE failures #2336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 12198ac.
kmabeeTT
requested review from
jnie-TT,
AleksKnezevic,
pilkicTT,
sdjordjevicTT,
svuckovicTT,
mtopalovicTT,
jserbedzijaTT,
azecevicTT,
nsmithtt,
mrakitaTT and
tapspatel
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 12198ac
Ticket
None
Problem description
This commit is breaking FE's, and the follow up PR (#2325) for it helps, but when combined with the original change still yields accuracy issues across many tt-torch models. We want to revert this change for now until figured out and merge both as per agreement with @kmabeeTT , @brataTT , @jserbedzijaTT , @mstojkovicTT
What's changed
Checklist