Fixing TTNN NOperand trait verify method visibility. #2334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdjordjevicTT
requested review from
svuckovicTT,
mtopalovicTT,
jserbedzijaTT and
azecevicTT
as code owners
mtopalovicTT
approved these changes
Feb 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
Closes #2333
Problem description
TTNN trait NOperandTTNN fails to call verifyTrait method:
https://github.com/tenstorrent/tt-mlir/blob/7bc75fc277ac11c6c0b2cfaeba25ad3d42af04be/include/ttmlir/Dialect/TTNN/IR/TTNNTraits.h#L76C7-L76C19
The issue is the visibility of the verifyTrait method, in the current code, it is private, hence it can't be called by the framework.
What's changed
Changed the visibility of verifyTrait from private to public, so the verifyTrait method is executed. Added tests to verify this behaviour.
Checklist