Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EmitC] Support MNIST #1663

Merged
merged 4 commits into from
Dec 25, 2024
Merged

[EmitC] Support MNIST #1663

merged 4 commits into from
Dec 25, 2024

Conversation

svuckovicTT
Copy link
Contributor

This PR enables MNIST in EmitC path.

Couple of smaller changes are bundled together to make this happen:

  • ttnn::empty changed its signature in the lib, the dialect was updated to reflect this and several call-sites were updated
  • ttnn::relu is mismodelled, added a converter in TTNNToEmitC
  • ttnn::matmul isn't DPS but we model is as if it is - added a converter in TTNNToEmitC to fix it and filed [TTNN dialect] Matmul op implemented as DPS, but isn't DPS in lib #1661
  • standalone build was broken after metal uplifts, now fixed

Closes #1175

odjuricicTT
odjuricicTT approved these changes Dec 24, 2024
View reviewed changes
Copy link
Contributor

@odjuricicTT odjuricicTT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Optimizer unittest changes look good.

sdjordjevicTT
sdjordjevicTT reviewed Dec 25, 2024
View reviewed changes
Copy link
Contributor

@sdjordjevicTT sdjordjevicTT left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few comments inline regarding the matmul conversion.

@svuckovicTT svuckovicTT enabled auto-merge (squash) December 25, 2024 13:00
@svuckovicTT svuckovicTT merged commit 436a9b8 into main Dec 25, 2024
21 checks passed
@svuckovicTT svuckovicTT deleted the svuckovic/emitc-mnist-fixes branch December 25, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdjordjevicTT sdjordjevicTT sdjordjevicTT approved these changes

@odjuricicTT odjuricicTT odjuricicTT approved these changes

@mtopalovicTT mtopalovicTT mtopalovicTT approved these changes

@nobradovictt nobradovictt Awaiting requested review from nobradovictt

@jserbedzijaTT jserbedzijaTT Awaiting requested review from jserbedzijaTT jserbedzijaTT is a code owner

@jnie-TT jnie-TT Awaiting requested review from jnie-TT jnie-TT is a code owner

@azecevicTT azecevicTT Awaiting requested review from azecevicTT azecevicTT is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[EmitC] Support MNIST in EmitC path
4 participants
@svuckovicTT @sdjordjevicTT @odjuricicTT @mtopalovicTT