-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delete using namespace in command queue interface header #18355
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for doing this - this is really great! 🔥
Adding using namespace ...
in .cpp makes sense to do the migration. I think ideally, we wouldn't even need that - spelling full types or adding explicit aliases for stuff we need is less invasive and more robust.
2f6ac22
to
2c71d7d
Compare
2c71d7d
to
ad74270
Compare
1b056ee
to
0f27aea
Compare
f1cabde
to
45a394b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great PR but be mindful this will basically clash with everything. Be super careful about merge conflicts and please make an announcement on slack when it's merged so those with open PRs are aware
a4e8fa1
to
815de5e
Compare
- Removed using namespace from command_queue_interface.hpp
815de5e
to
eecaa6e
Compare
Ticket
#18325
Problem description
api/command_queue_interface.hpp
has ausing namespace tt::tt_metal
at the top of the file in the global namespace, causing the entire repository's global namespace to be polluted and making conflicting types.What's changed
using namespace tt::tt_metal
from the headertt::tt_metal
in header files.Checklist