Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upsize EDM Fabric Buffer Slot Size To Improver Perf for Workloads Using bfp8 #17991

Closed
wants to merge 12 commits into from

Conversation

SeanNijjar
Copy link
Contributor

@SeanNijjar SeanNijjar commented Feb 19, 2025

Ticket

Link to Github Issue

Problem description

The current default EDM buffer slot size is 4096 which can only store 3 bfp8 tiles. There is enough space in erisc L1 unreserved space such that all channels can have a power of 2 buffer slot count and also have a slot size of 4 bfp8 tiles. There is inefficient space for 5 bfp8 tiles per slot.

What's changed

This PR bumps up the buffer slot size to fit 4 bfp8 tiles per packet, which is preferable for workloads with bfp8 tiles sent over fabric.

Checklist

@SeanNijjar SeanNijjar changed the title Snijjar/bigger edm buffer Upsize EDM Fabric Buffer Slot Size To Improver Perf for Workloads Using bfp8 Feb 19, 2025
@SeanNijjar
Copy link
Contributor Author

wrong branch

@SeanNijjar SeanNijjar closed this Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant