[UMD] Remove a couple of leftover usages of old soc descriptor API #17707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
broskoTT
requested review from
abhullar-tt,
pgkeller,
aliuTT,
tt-aho,
tt-dma,
tt-asaigal,
ubcheema,
cfjchu and
omilyutin-tt
as code owners
abhullar-tt
approved these changes
Feb 20, 2025
broskoTT
added a commit
to tenstorrent/tt-umd
that referenced
this pull request
Feb 27, 2025
### Issue Last one for #439 ### Description Finally removing old harvesting code. All the tt_metal's usages have been moved to the new soc_descriptor and core_coordinate_manager apis. ### List of the changes - Remove using_harvested_soc_descriptors, get_harvesting_masks_for_soc_descriptors and translate_to_noc_table_coords functions, and performed_harvesting, harvested_rows_per_target, translation_tables_en from the public cluster API - Remove harvesting code from Cluster with many internal functions - move old soc_descriptor structures to be private. - Adjust tests accordingly - Added noc_translation public member to soc_descriptor. Verify that the one passed through constructor and through soc_descriptor matches. This code should be improved. ### Testing Code builds ### API Changes There are no breaking API changes in this PR. Related metal PRs prior to this change: tenstorrent/tt-metal#17003 tenstorrent/tt-metal#17306 tenstorrent/tt-metal#17543 tenstorrent/tt-metal#17620 tenstorrent/tt-metal#17642 tenstorrent/tt-metal#17645 tenstorrent/tt-metal#17674 tenstorrent/tt-metal#17678 tenstorrent/tt-metal#17707
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
Related to #17002
Problem description
A couple of leftover usages of old soc descriptor API. After this and other PRs from this set, tt-metal will finally build with harvesting code completely removed from tt::umd::Cluster and members of tt_SocDescriptor made private, so that all usages are forced through get_cores() and other APIs.
Related PRs:
#17620
#17642
#17645
#17674
#17678
What's changed
Checklist