Fix ttnn.reallocate when unaligned RM tensors are used
#16192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
esmalTT
requested review from
ayerofieiev-tt,
dmakoviichuk-tt,
rfurko-tt,
cfjchu,
TT-BrianLiu,
razorback3,
dongjin-na,
bbradelTT,
ntarafdar,
sjameelTT,
jaykru-tt,
yugi957,
jvegaTT and
llongTT
as code owners
esmalTT
force-pushed
the
esmal/fix-realloc-unaligned
branch
from
a6f13b2 to
493a8c1
Compare
ntarafdar
reviewed
Dec 19, 2024
| @@ -18,7 +18,7 @@ void kernel_main() { | |||
| constexpr uint32_t src_cb_id = get_compile_time_arg_val(0); | |||
| constexpr uint32_t dst_cb_id = get_compile_time_arg_val(1); | |||
|
|
|||
| uint32_t src_cb_base_addr = get_write_ptr(src_cb_id); // TODO change to read | |||
| uint32_t src_cb_base_addr = get_read_ptr(src_cb_id); | |||
There was a problem hiding this comment.
love seeing TODOs being removed
There was a problem hiding this comment.
seemed like a low hanging one 🥲
ntarafdar
approved these changes
Dec 19, 2024
bbradelTT
approved these changes
Dec 19, 2024
This was referenced Dec 19, 2024
esmalTT
force-pushed
the
esmal/fix-realloc-unaligned
branch
from
493a8c1 to
1f47b62
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
Problem description
Padding added in unaligned row-major tensors sizes was not being considered in the
ttnn.moveop, which is the underlying implementation forttnn.reallocate.This was causing issues in Stable Diffusion, since it uses unaligned RM tensors.
What's changed
Checklist