Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TT-Train ]added tests for sum and mean #16152

Merged
merged 12 commits into from
Dec 19, 2024
Merged

[TT-Train ]added tests for sum and mean #16152

merged 12 commits into from
Dec 19, 2024

Conversation

dmakoviichuk-tt
Copy link
Contributor

@dmakoviichuk-tt dmakoviichuk-tt commented Dec 18, 2024 •
edited
Loading

Problem description

We need to know that ttnn reduce ops are almost the same as moreh.

What's changed

  • Added sum test
  • Added mean test
  • Updated sum_over_dim
Screenshot 2024-12-18 at 1 56 19 PM

Checklist

  • Post commit CI passes
  • Blackhole Post commit (if applicable)
  • Model regression CI testing passes (if applicable)
  • Device performance regression CI testing passes (if applicable)
  • (For models and ops writers) Full new models tests passes
  • New/Existing tests provide coverage for changes

https://github.com/tenstorrent/tt-metal/actions/runs/12405523060

rfurko-tt
rfurko-tt approved these changes Dec 18, 2024
View reviewed changes
Copy link
Contributor

@rfurko-tt rfurko-tt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

rfurko-tt
rfurko-tt reviewed Dec 19, 2024
View reviewed changes
dmakoviichuk-tt and others added 10 commits December 18, 2024 19:10
@dmakoviichuk-tt @rfurko-tt
Update tt-train/sources/ttml/ttnn_fixed/trivial_ttnn_ops.cpp
14199b2 
Co-authored-by: Roman Furko <[email protected]>
@dmakoviichuk-tt @rfurko-tt
Update tt-train/sources/ttml/ttnn_fixed/trivial_ttnn_ops.cpp
7718c52 
Co-authored-by: Roman Furko <[email protected]>
@dmakoviichuk-tt @rfurko-tt
Update tt-train/sources/ttml/ttnn_fixed/trivial_ttnn_ops.cpp
5a1744e 
Co-authored-by: Roman Furko <[email protected]>
@dmakoviichuk-tt @rfurko-tt
Update tt-train/sources/ttml/ttnn_fixed/trivial_ttnn_ops.cpp
eb4bd39 
Co-authored-by: Roman Furko <[email protected]>
@dmakoviichuk-tt @rfurko-tt
Update tt-train/sources/ttml/ttnn_fixed/trivial_ttnn_ops.hpp
1fc32cf 
Co-authored-by: Roman Furko <[email protected]>
@dmakoviichuk-tt @rfurko-tt
Update tt-train/sources/ttml/ttnn_fixed/trivial_ttnn_ops.hpp
293f265 
Co-authored-by: Roman Furko <[email protected]>
@dmakoviichuk-tt @rfurko-tt
Update tt-train/sources/ttml/ttnn_fixed/trivial_ttnn_ops.cpp
a87f529 
Co-authored-by: Roman Furko <[email protected]>
@dmakoviichuk-tt @rfurko-tt
Update tt-train/sources/ttml/ttnn_fixed/trivial_ttnn_ops.hpp
9874d0e 
Co-authored-by: Roman Furko <[email protected]>
@dmakoviichuk-tt @rfurko-tt
Update tt-train/sources/ttml/ttnn_fixed/trivial_ttnn_ops.hpp
a22376a 
Co-authored-by: Roman Furko <[email protected]>
@dmakoviichuk-tt
Merge branch 'main' into DM/reduce_tt_train
033b4af
@dmakoviichuk-tt dmakoviichuk-tt merged commit 5c91e97 into main Dec 19, 2024
182 of 184 checks passed
@dmakoviichuk-tt dmakoviichuk-tt deleted the DM/reduce_tt_train branch December 19, 2024 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rfurko-tt rfurko-tt rfurko-tt approved these changes

Assignees
No one assigned
Labels
TT-train
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dmakoviichuk-tt @rfurko-tt