Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#0: aligning conv2d transpose as conv #16128

Merged
merged 1 commit into from
Dec 19, 2024
Merged

Conversation

shwetankTT
Copy link
Contributor

@shwetankTT shwetankTT commented Dec 18, 2024

Ticket

None

Problem description

aligning conv2d transpose as conv

What's changed

Created python interface for conv2d transpose. Align the implementation with conv2d.

Checklist

  • Post commit CI passes
  • Blackhole Post commit (if applicable)
  • Model regression CI testing passes (if applicable)
  • Device performance regression CI testing passes (if applicable)
  • (For models and ops writers) Full new models tests passes
  • New/Existing tests provide coverage for changes

@shwetankTT
Copy link
Contributor Author

@sankarmanoj-tt Could you take a quick look at this Draft PR?

@shwetankTT shwetankTT marked this pull request as ready for review December 18, 2024 12:26
Copy link
Member

@ayerofieiev-tt ayerofieiev-tt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is a bit annoying that we have to maintain 2 distinct functions here.
I assume we are precisely following PyTorch here.

I encourage the team to review if this makes sense taking into account amount of code duplication to maintain going forward.

@shwetankTT shwetankTT merged commit f1ccbb6 into main Dec 19, 2024
226 of 227 checks passed
@shwetankTT shwetankTT deleted the shwetankTT/conv_transpose branch December 19, 2024 01:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants