Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#15868: use a buffer's size when creating its CB in groupnorm #16093

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

bbradelTT
Copy link
Contributor

@bbradelTT bbradelTT commented Dec 17, 2024

Ticket

Link to Github Issue #15868

Problem description

  • Some group norm tests are failing with Debug Build with an assert about CB size
  • The underlying reason is that the in0 CB was always sized to the nearest tile, even when the input was row major and therefore smaller

What's changed

  • Set the CB size for in0 based on the per bank size to get the right size for row major and tile input

Checklist

@bbradelTT bbradelTT force-pushed the bbradel-15868_cb_page branch from 95fae4f to e0fb8f3 Compare December 17, 2024 14:07
@bbradelTT
Copy link
Contributor Author

@TT-BrianLiu added you as a reviewer to see if you're ok with this change.

@bbradelTT bbradelTT merged commit 5f48c90 into main Jan 8, 2025
182 of 184 checks passed
@bbradelTT bbradelTT deleted the bbradel-15868_cb_page branch January 8, 2025 15:05
hschoi4448 pushed a commit that referenced this pull request Feb 20, 2025
### Ticket
Link to Github Issue
#15868

### Problem description
- Some group norm tests are failing with Debug Build with an assert
about CB size
- The underlying reason is that the in0 CB was always sized to the
nearest tile, even when the input was row major and therefore smaller

### What's changed
- Set the CB size for in0 based on the per bank size to get the right
size for row major and tile input

### Checklist
- [x] Post commit CI passes across
https://github.com/tenstorrent/tt-metal/actions/runs/12360041457 and
https://github.com/tenstorrent/tt-metal/actions/runs/12374697868 all
sub-jobs pass at least once
- [x] Blackhole Post commit (if applicable)
https://github.com/tenstorrent/tt-metal/actions/runs/12360044285
- [x] Model regression CI testing passes (if applicable)
https://github.com/tenstorrent/tt-metal/actions/runs/12360048449
- [x] Device performance regression CI testing passes (if applicable)
https://github.com/tenstorrent/tt-metal/actions/runs/12360046481
- [ ] **(For models and ops writers)** Full [new
models](https://github.com/tenstorrent/tt-metal/actions/workflows/full-new-models-suite.yaml)
tests passes
- [x] New/Existing tests provide coverage for changes (in Debug)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants