Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#0: Add bc to docker container for pgm dispatch math #16030

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

tt-rkim
Copy link
Collaborator

@tt-rkim tt-rkim commented Dec 13, 2024

Ticket

Blocking @jbaumanTT

Problem description

the container doesn't come with bc by default

What's changed

Added bc for math

I'm wondering if we should take it out later and put it directly as a sudo apt install command in the workflow, so we don't set the precedent of chucking stuff into the image.

Checklist

  • Post commit CI passes
  • Blackhole Post commit (if applicable)
  • Model regression CI testing passes (if applicable)
  • Device performance regression CI testing passes (if applicable)
  • (For models and ops writers) Full new models tests passes
  • New/Existing tests provide coverage for changes

@tt-rkim tt-rkim requested a review from a team as a code owner December 13, 2024 23:21
@tt-rkim tt-rkim merged commit 7bd827c into main Dec 13, 2024
201 of 203 checks passed
@tt-rkim tt-rkim deleted the rkim/0-add-bc-frequent-pipeline branch December 13, 2024 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant