Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#15836: Update reads, writes, and synchronize ttnn apis to take in sub device ids #15812

Merged
merged 2 commits into from
Dec 10, 2024

Conversation

tt-aho
Copy link
Contributor

@tt-aho tt-aho commented Dec 8, 2024

Ticket

#15836

Problem description

Need to expose the new sub_device_ids args for various metal apis up the stack to enable usage in python. The sub_device_ids parameters are mostly used so that user can specify what dispatch should wait/stall on. Ex. If we have a persistent program on one sub-device, and regular programs on another, we'd only want to block/stall on the sub-device running regular programs during runtime, and only block on all programs at the end when the persistent program finishes as well, otherwise if we always stall on all sub-devices we'd hang waiting for the persistent program to finish when we only need the regular program to finish.

What's changed

Update ttnn apis up the stack to propagate sub_device_ids down to various metal apis.

Checklist

Copy link
Contributor

@omilyutin-tt omilyutin-tt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have an issue # for this? Also, is there any documentation related to sub devices, or design docs? It isn't very clear how / when to use sub devices.

@tt-aho tt-aho changed the title #0: Update reads, writes, and synchronize ttnn apis to take in sub device ids #15836: Update reads, writes, and synchronize ttnn apis to take in sub device ids Dec 9, 2024
Copy link
Contributor

@omilyutin-tt omilyutin-tt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Member

@ayerofieiev-tt ayerofieiev-tt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hope the team will find time to review these APIs and sort things out.

@tt-aho tt-aho merged commit d1a9014 into main Dec 10, 2024
176 of 184 checks passed
@tt-aho tt-aho deleted the aho/pybinds branch December 10, 2024 14:36
@blozano-tt
Copy link
Contributor

blozano-tt commented Dec 13, 2024

@tt-aho could this PR be at fault for breaking T3K unit tests?

https://github.com/tenstorrent/tt-metal/actions/runs/12306978859/job/34350073706

cc: @ttmchiou

Running this job at the commit just before your commits, to confirm:

https://github.com/tenstorrent/tt-metal/actions/runs/12309298990

@blozano-tt blozano-tt restored the aho/pybinds branch December 13, 2024 03:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants