Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#13621: enable default fp32 acc for reduce #15665

Merged
merged 1 commit into from
Dec 6, 2024
Merged

Conversation

bbradelTT
Copy link
Contributor

@bbradelTT bbradelTT commented Dec 3, 2024

Ticket

Link to Github Issue #13621

Problem description

reduce sum is not very accurate because fp32 acc for reduce was not enabled by default

What's changed

enable fp32 acc for reduce by default

Checklist

@bbradelTT bbradelTT force-pushed the bbradel-13621_fp32 branch 2 times, most recently from 1dfa9cd to 456f7cb Compare December 5, 2024 20:34
Copy link
Contributor

@asandhupatlaTT asandhupatlaTT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@bbradelTT bbradelTT merged commit a8a044a into main Dec 6, 2024
112 of 119 checks passed
@bbradelTT bbradelTT deleted the bbradel-13621_fp32 branch December 6, 2024 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants