Detecting arch through cluster descriptor #15564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
broskoTT
requested review from
bbradelTT,
asandhupatlaTT,
sjameelTT,
abhullar-tt,
pgkeller,
aliuTT,
tt-aho,
tt-dma,
tt-asaigal and
ubcheema
as code owners
2 tasks
bbradelTT
approved these changes
Nov 29, 2024
broskoTT
force-pushed
the
brosko/detect_arch
branch
from
c01f70c to
5c3779a
Compare
abhullar-tt
approved these changes
Dec 4, 2024
broskoTT
added a commit
to tenstorrent/tt-umd
that referenced
this pull request
Dec 4, 2024
### Issue Related to #99 Aftermath of #175 ### Description Make detect_arch available through cluster_descriptor which should be the only real endpoint when reading information about chips in the cluster. ### List of the changes - Removed detect_arch from cluster.h - Added arch map in ClusterDescriptor - Added static tt_ClusterDescriptor::detect_arch which should be used instead of previously defined detect_arch ### Testing Wrote a test which verifies this works as intended ### API Changes This PR has API changes: - [x] tt_metal approved PR pointing to this branch: tenstorrent/tt-metal#15564 - [x] tt_debuda approved PR pointing to this branch: tenstorrent/tt-exalens#201
broskoTT
added a commit
to tenstorrent/tt-umd
that referenced
this pull request
Dec 5, 2024
### Issue Fix issue after #358 ### Description This change creates problems on clang-tidy run on tt_metal. ### List of the changes - Reverted part of change from referenced PR ### Testing Both bellow branches and runs have detect_arch commit reverted on UMD, and have "don't run clang-tidy" commit reverted on tt_metal All post commit run on tt_metal prior to change: https://github.com/tenstorrent/tt-metal/actions/runs/12177536236 All post commit run on tt_metal after change: https://github.com/tenstorrent/tt-metal/actions/runs/12177582506 ### API Changes There are no API changes in this PR. Note that "build client" job failure is expected due to this PR not being checked in: tenstorrent/tt-metal#15564
broskoTT
force-pushed
the
brosko/detect_arch
branch
from
8ab3e94 to
bf8a464
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
Related to #13948
Problem description
detect_arch was in the global namespace.
Now putting this functionality in the right place. It also now works with logical ids, as opposed to pci device enumeration id.
Related UMD change tenstorrent/tt-umd#345
What's changed
Changed detect_arch to tt_ClusterDescriptor::get_arch()
BoardType::DEFAULT changed to UNKNOWN
Also changed detect_arch to PCIDevice::enumerate_devices_info(), due to ClusterDescriptor::create() not working.
Checklist