-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for rank-n tensors to tilize and untilize #15520
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clang-Tidy
found issue(s) with the introduced code (1/1)
174d1ad
to
1b2787f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clang-Tidy
found issue(s) with the introduced code (1/1)
auto unsqueezed_tensor = ttnn::reshape(output, *original_shape); | ||
return unsqueezed_tensor; | ||
}, | ||
.operation = std::move(base_untilize)}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
parameter base_untilize
is passed by value and only copied once; consider moving it to avoid unnecessary copies
.operation = std::move(base_untilize)}); | |
.operation = std::move(base_untilize)}); |
auto unsqueezed_tensor = ttnn::reshape(output, *original_shape); | ||
return unsqueezed_tensor; | ||
}, | ||
.operation = std::move(base_tilize)}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
parameter base_tilize
is passed by value and only copied once; consider moving it to avoid unnecessary copies
.operation = std::move(base_tilize)}); | |
.operation = std::move(base_tilize)}); |
b491105
to
d613360
Compare
I messed up a few of the tilize tests with an unnecessary refactor. Re-running post-commit to be safe then should be able to merge. |
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
d613360
to
3c434b9
Compare
Ticket
#15165
What's changed
Checklist