enable dps ops for matmul #15285
Merged
enable dps ops for matmul #15285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asandhupatlaTT
requested review from
ayerofieiev-tt,
dmakoviichuk-tt,
rfurko-tt,
cfjchu,
TT-BrianLiu,
razorback3,
dongjin-na,
bbradelTT and
yugaoTT
as code owners
asandhupatlaTT
force-pushed
the
matmul_dps_ops
branch
from
1777370 to
5bfed25
Compare
bbradelTT
reviewed
Nov 29, 2024
bbradelTT
reviewed
Dec 2, 2024
ttnn/cpp/ttnn/operations/experimental/ccl/all_gather_matmul/device/all_gather_matmul_op.cpp
Outdated
Show resolved
Hide resolved
bbradelTT
reviewed
Dec 4, 2024
ttnn/cpp/ttnn/operations/experimental/ccl/all_gather_matmul/device/all_gather_matmul_op.cpp
Outdated
Show resolved
Hide resolved
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
ttnn/cpp/ttnn/operations/experimental/ccl/all_gather_matmul/device/all_gather_matmul_op.cpp
Outdated
Show resolved
Hide resolved
ttnn/cpp/ttnn/operations/experimental/ccl/all_gather_matmul/device/all_gather_matmul_op.cpp
Outdated
Show resolved
Hide resolved
bbradelTT
approved these changes
Dec 4, 2024
bbradelTT
requested changes
Dec 5, 2024
eyonland
reviewed
Dec 5, 2024
asandhupatlaTT
force-pushed
the
matmul_dps_ops
branch
from
be88323 to
5159d69
Compare
bbradelTT
approved these changes
Dec 6, 2024
asandhupatlaTT
force-pushed
the
matmul_dps_ops
branch
from
3de4b61 to
7073e2f
Compare
Signed-off-by: Amruth Sandhupatla <[email protected]>
Signed-off-by: Amruth Sandhupatla <[email protected]>
Signed-off-by: Amruth Sandhupatla <[email protected]>
Signed-off-by: Amruth Sandhupatla <[email protected]>
Signed-off-by: Amruth Sandhupatla <[email protected]>
Signed-off-by: Amruth Sandhupatla <[email protected]>
Signed-off-by: Amruth Sandhupatla <[email protected]>
Signed-off-by: Amruth Sandhupatla <[email protected]>
Signed-off-by: Amruth Sandhupatla <[email protected]>
Signed-off-by: Amruth Sandhupatla <[email protected]>
Signed-off-by: Amruth Sandhupatla <[email protected]>
Signed-off-by: Amruth Sandhupatla <[email protected]>
Signed-off-by: Amruth Sandhupatla <[email protected]>
Signed-off-by: Amruth Sandhupatla <[email protected]>
Signed-off-by: Amruth Sandhupatla <[email protected]>
Signed-off-by: Amruth Sandhupatla <[email protected]>
Signed-off-by: Amruth Sandhupatla <[email protected]>
Signed-off-by: Amruth Sandhupatla <[email protected]>
Signed-off-by: Amruth Sandhupatla <[email protected]>
asandhupatlaTT
force-pushed
the
matmul_dps_ops
branch
from
154e2bb to
9edd1f9
Compare
TT-BrianLiu
approved these changes
Dec 19, 2024
SeanNijjar
approved these changes
Dec 19, 2024
That's broken on main. You'd need to just check that you're not introducing any new failures. |
https://github.com/tenstorrent/tt-metal/actions/runs/12417202012 @SeanNijjar |
azecevicTT
added a commit
to tenstorrent/tt-mlir
that referenced
this pull request
Feb 23, 2025
TTNN supports `tranpose_a` and `transpose_b` paramaters as default valued boolean (false) parameter for matmul and linear op. Some frontends also have this parameter. This PR introduces it. I have also refactored verifiers in some places. I have removed `test/ttmlir/Dialect/TTIR/matmul/matmul_tests_positive.mlir` because there is the same `matmul_tests_positive.mlir` in `TTNN` directory and `TTIR` checks are done entirely as a part of that test. Canonicalization pattern is added that transforms `matmul(tranpose(lhs), rhs, transpose_lhs, transpose_rhs)` to `matmul(lhs, rhs, !transpose_lhs, transpose_rhs)`. Same for the `rhs` and linear op. I have also updated runtime to reflect a change in `tt-metal` tenstorrent/tt-metal#15285. I have opened a separate issue regarding a "Adding an op" doc, because matmul is used as an example there. #1749 Closes #1305
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
Link to Github Issue:
#15038
Problem description
Provide context for the problem.
Dps ops are not being generated in MLIR for matmul op.
What's changed
Describe the approach used to solve the problem.
Summarize the changes made and its impact.
Enabled std::optional for ourput tensor as seen for other dps supported ops such as Embedding & element-wise ops
Checklist