Fix simulator setup #15227
Merged
Fix simulator setup #15227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vtangTT
force-pushed
the
vtangTT/fix_simulator
branch
from
52384c4 to
e35523c
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
vtangTT
force-pushed
the
vtangTT/fix_simulator
branch
5 times, most recently
from
a952a66 to
fa8455c
Compare
vtangTT
requested review from
abhullar-tt,
pgkeller,
aliuTT,
tt-aho,
tt-dma,
tt-asaigal,
ubcheema,
davorchap and
cfjchu
as code owners
|
Please drop |
abhullar-tt
reviewed
Nov 28, 2024
vtangTT
force-pushed
the
vtangTT/fix_simulator
branch
from
55ee212 to
6bd9ff6
Compare
vtangTT
force-pushed
the
vtangTT/fix_simulator
branch
from
ed18000 to
f072046
Compare
abhullar-tt
reviewed
Nov 28, 2024
| @@ -10,7 +10,7 @@ arc: | |||
| [ ] | |||
|
|
|||
| pcie: | |||
| [ ] | |||
| [ 0-0 ] | |||
There was a problem hiding this comment.
does the WH simulated soc have pcie cores? If not then I think we should remove this
There was a problem hiding this comment.
Yep should've removed this too, ty.
Removed now.
tt_metal/impl/device/device.cpp
Outdated
| this->device_kernel_defines_.emplace("PCIE_NOC_Y", std::to_string(pcie_cores[0].y)); | ||
| this->device_kernel_defines_.emplace("PCIE_NOC1_X", std::to_string(tt::tt_metal::hal.noc_coordinate(NOC::NOC_1, grid_size.x, pcie_cores[0].x))); | ||
| this->device_kernel_defines_.emplace("PCIE_NOC1_Y", std::to_string(tt::tt_metal::hal.noc_coordinate(NOC::NOC_1, grid_size.x, pcie_cores[0].y))); | ||
| if (std::getenv("TT_METAL_SIMULATOR_EN")) { |
There was a problem hiding this comment.
Passing in PCIe core to device temporary until we enable virtual coordinates but for now maybe we should:
Suggested change
| if (std::getenv("TT_METAL_SIMULATOR_EN")) { | |
| CoreCoord pcie_core = pcie_cores.empty() ? grid_size : pcie_cores[0] | |
| then use this as PCIE_NOC_X and PCIE_NOC_Y and calculate PCIE_NOC1* |
There was a problem hiding this comment.
I've removed the if cond with the env var, but pcie_noc1* are still hardcoded to 14 or 11 like before if pcie_cores.empty()
Not sure if there's a better way of doing this?
vtangTT
force-pushed
the
vtangTT/fix_simulator
branch
from
633bd19 to
567ea4e
Compare
abhullar-tt
approved these changes
Dec 2, 2024
- HACK for passing BH pcie coordinates during simulation mode - Correct compute grid size for BH simulator
vtangTT
force-pushed
the
vtangTT/fix_simulator
branch
from
567ea4e to
e9646b6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
Link to Github Issue
Problem description
Provide context for the problem.
What's changed
Describe the approach used to solve the problem.
Summarize the changes made and its impact.
Checklist