Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#0: Allow Users to provide extra tag for T3K choose your own pipeline #14873

Merged
merged 6 commits into from
Nov 8, 2024
Merged

#0: Allow Users to provide extra tag for T3K choose your own pipeline #14873

merged 6 commits into from
Nov 8, 2024

Conversation

blozano-tt
Copy link
Contributor

Ticket

NA

Problem description

Choose your own pipeline workflow dispatch does not allow users to target specific runners.

What's changed

Allow an optional extra tag to be supplied during workflow dispatch.
Currently only applied to T3K workflows.

Checklist

  • Post commit CI passes
  • Blackhole Post commit (if applicable)
  • Model regression CI testing passes (if applicable)
  • Device performance regression CI testing passes (if applicable)
  • New/Existing tests provide coverage for changes

ttmchiou
ttmchiou reviewed Nov 7, 2024
View reviewed changes
.github/workflows/t3000-demo-tests-impl.yaml Outdated
@@ -23,7 +28,7 @@ jobs:
ARCH_NAME: ${{ matrix.test-group.arch }}
LOGURU_LEVEL: INFO
LD_LIBRARY_PATH: ${{ github.workspace }}/build/lib
runs-on: ["arch-wormhole_b0", "config-t3000", "in-service", "pipeline-perf"]
runs-on: ["arch-wormhole_b0", "config-t3000", "in-service", "pipeline-functional", ${{ inputs.extra-tag }}]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shoud set extra-tag as default to in-service.

That way you can use this workflow to triage OOS units as well

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh good catch!

@blozano-tt
Copy link
Contributor Author

@ttmchiou @afuller-TT

Looks like it is working now. Sorry I had to iteratively hack.

https://github.com/tenstorrent/tt-metal/actions/runs/11733788167

@blozano-tt blozano-tt merged commit 1ede74c into main Nov 8, 2024
17 of 29 checks passed
@blozano-tt blozano-tt deleted the blozano/extra_tag_t3k branch November 8, 2024 01:02
ct-clmsn pushed a commit to ct-clmsn/tt-metal that referenced this pull request Nov 12, 2024
@blozano-tt
[skip ci] #0: Allow Users to provide extra tag for T3K choose your ow…
66599e4 
…n pipeline (tenstorrent#14873)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afuller-TT afuller-TT afuller-TT left review comments

@ttmchiou ttmchiou ttmchiou approved these changes

@tt-rkim tt-rkim Awaiting requested review from tt-rkim

@TT-billteng TT-billteng Awaiting requested review from TT-billteng

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@blozano-tt @ttmchiou @afuller-TT