-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#0: Workflow to test compatibility with TTNN Project Template #14442
Conversation
67a702a
to
859d390
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clang-Tidy
found issue(s) with the introduced code (1/8)
...tt_metal/tt_metal/unit_tests_fast_dispatch/multichip/test_eth_ring_gather_EnqueueProgram.cpp
Outdated
Show resolved
Hide resolved
...tt_metal/tt_metal/unit_tests_fast_dispatch/multichip/test_eth_ring_gather_EnqueueProgram.cpp
Outdated
Show resolved
Hide resolved
...tt_metal/tt_metal/unit_tests_fast_dispatch/multichip/test_eth_ring_gather_EnqueueProgram.cpp
Outdated
Show resolved
Hide resolved
...tt_metal/tt_metal/unit_tests_fast_dispatch/multichip/test_eth_ring_gather_EnqueueProgram.cpp
Outdated
Show resolved
Hide resolved
ttnn/cpp/ttnn/operations/ccl/reduce_scatter/device/reduce_scatter_op.cpp
Outdated
Show resolved
Hide resolved
ttnn/cpp/ttnn/operations/ccl/reduce_scatter/device/reduce_scatter_op.cpp
Outdated
Show resolved
Hide resolved
ttnn/cpp/ttnn/operations/bernoulli/device/bernoulli_device_operation.hpp
Outdated
Show resolved
Hide resolved
ttnn/cpp/ttnn/operations/moreh/moreh_layer_norm/device/moreh_layer_norm_device_operation.hpp
Outdated
Show resolved
Hide resolved
ttnn/cpp/ttnn/operations/eltwise/binary/device/broadcast_height_multi_core_program_factory.cpp
Outdated
Show resolved
Hide resolved
ttnn/cpp/ttnn/operations/moreh/moreh_norm/device/moreh_norm_device_operation.hpp
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clang-Tidy
found issue(s) with the introduced code (2/8)
ttnn/cpp/ttnn/operations/moreh/moreh_arange/device/moreh_arange_device_operation.hpp
Outdated
Show resolved
Hide resolved
ttnn/cpp/ttnn/operations/moreh/moreh_matmul/device/moreh_matmul_device_operation.hpp
Outdated
Show resolved
Hide resolved
...lization/layernorm_distributed/device/multi_core/layernorm_post_all_gather_op_multi_core.cpp
Outdated
Show resolved
Hide resolved
ttnn/cpp/ttnn/operations/conv/conv2d/device/conv2d_op_sharded_program_factory.cpp
Outdated
Show resolved
Hide resolved
ttnn/cpp/ttnn/operations/conv/conv2d/device/conv2d_op_sharded_program_factory.cpp
Outdated
Show resolved
Hide resolved
ttnn/cpp/ttnn/operations/conv/conv2d/device/conv2d_op_sharded_program_factory.cpp
Outdated
Show resolved
Hide resolved
...mental/transformer/rotary_embedding_llama/device/rotary_embedding_llama_device_operation.cpp
Outdated
Show resolved
Hide resolved
ttnn/cpp/ttnn/operations/normalization/layernorm/device/multi_core/layernorm_op_multi_core.cpp
Outdated
Show resolved
Hide resolved
ttnn/cpp/ttnn/operations/normalization/layernorm/device/multi_core/layernorm_op_multi_core.cpp
Outdated
Show resolved
Hide resolved
tests/ttnn/unit_tests/gtests/ttnn_multi_command_queue_fixture.hpp
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clang-Tidy
found issue(s) with the introduced code (3/8)
...ions/eltwise/binary/device/broadcast_height_multi_core_sharded_optimized_program_factory.cpp
Outdated
Show resolved
Hide resolved
tests/tt_metal/tt_metal/unit_tests_common/common/common_fixture.hpp
Outdated
Show resolved
Hide resolved
ttnn/cpp/ttnn/operations/normalization/softmax/device/multi_core/softmax_op_multi_core.cpp
Outdated
Show resolved
Hide resolved
ttnn/cpp/ttnn/operations/moreh/moreh_getitem/device/moreh_getitem_rm_factory.cpp
Outdated
Show resolved
Hide resolved
ttnn/cpp/ttnn/operations/moreh/moreh_getitem/device/moreh_getitem_rm_factory.cpp
Outdated
Show resolved
Hide resolved
...l/tt_metal/unit_tests_fast_dispatch_single_chip_multi_queue/common/command_queue_fixture.hpp
Outdated
Show resolved
Hide resolved
tests/tt_metal/tt_metal/unit_tests_fast_dispatch/multichip/test_eth_EnqueueProgram.cpp
Outdated
Show resolved
Hide resolved
tests/tt_metal/tt_metal/unit_tests_fast_dispatch/multichip/test_eth_EnqueueProgram.cpp
Outdated
Show resolved
Hide resolved
tests/tt_metal/tt_metal/unit_tests_fast_dispatch/multichip/test_eth_EnqueueProgram.cpp
Outdated
Show resolved
Hide resolved
tests/tt_metal/tt_metal/unit_tests_fast_dispatch/multichip/test_eth_EnqueueProgram.cpp
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clang-Tidy
found issue(s) with the introduced code (4/8)
tests/tt_metal/tt_metal/unit_tests/multichip/basic_eth_kernels.cpp
Outdated
Show resolved
Hide resolved
tests/tt_metal/tt_metal/unit_tests/multichip/basic_eth_kernels.cpp
Outdated
Show resolved
Hide resolved
tests/tt_metal/tt_metal/unit_tests/multichip/basic_eth_kernels.cpp
Outdated
Show resolved
Hide resolved
tests/tt_metal/tt_metal/unit_tests/multichip/basic_eth_kernels.cpp
Outdated
Show resolved
Hide resolved
tests/tt_metal/tt_metal/unit_tests/multichip/basic_eth_kernels.cpp
Outdated
Show resolved
Hide resolved
tests/tt_metal/tt_metal/unit_tests/multichip/basic_eth_kernels.cpp
Outdated
Show resolved
Hide resolved
tests/tt_metal/tt_metal/unit_tests/multichip/basic_eth_kernels.cpp
Outdated
Show resolved
Hide resolved
tests/tt_metal/tt_metal/unit_tests/multichip/basic_eth_kernels.cpp
Outdated
Show resolved
Hide resolved
ttnn/cpp/ttnn/operations/data_movement/clone/device/clone_device_operation.hpp
Outdated
Show resolved
Hide resolved
...up_norm_backward/device/input_grad/moreh_group_norm_backward_input_grad_device_operation.hpp
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clang-Tidy
found issue(s) with the introduced code (5/8)
ttnn/cpp/ttnn/operations/moreh/moreh_cumsum/device/moreh_cumsum_device_operation.hpp
Outdated
Show resolved
Hide resolved
ttnn/cpp/ttnn/operations/moreh/moreh_softmax/device/moreh_softmax_device_operation.hpp
Outdated
Show resolved
Hide resolved
...alization/layernorm_distributed/device/multi_core/layernorm_pre_all_gather_op_multi_core.cpp
Outdated
Show resolved
Hide resolved
.../cpp/ttnn/operations/moreh/moreh_sum_backward/device/moreh_sum_backward_device_operation.hpp
Outdated
Show resolved
Hide resolved
tests/tt_metal/tt_metal/unit_tests/multichip/erisc_app_direct_send.cpp
Outdated
Show resolved
Hide resolved
tests/tt_metal/tt_metal/unit_tests/multichip/erisc_app_direct_send.cpp
Outdated
Show resolved
Hide resolved
tests/tt_metal/tt_metal/unit_tests/multichip/erisc_app_direct_send.cpp
Outdated
Show resolved
Hide resolved
tests/tt_metal/tt_metal/unit_tests/multichip/erisc_app_direct_send.cpp
Outdated
Show resolved
Hide resolved
tests/tt_metal/tt_metal/unit_tests/multichip/erisc_app_direct_send.cpp
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clang-Tidy
found issue(s) with the introduced code (6/8)
ttnn/cpp/ttnn/operations/moreh/moreh_group_norm/device/moreh_group_norm_device_operation.hpp
Outdated
Show resolved
Hide resolved
...pp/ttnn/operations/moreh/moreh_norm_backward/device/moreh_norm_backward_device_operation.hpp
Outdated
Show resolved
Hide resolved
ttnn/cpp/ttnn/operations/moreh/moreh_getitem/device/moreh_getitem_tilized_factory.cpp
Outdated
Show resolved
Hide resolved
ttnn/cpp/ttnn/operations/moreh/moreh_getitem/device/moreh_getitem_tilized_factory.cpp
Outdated
Show resolved
Hide resolved
ttnn/cpp/ttnn/operations/normalization/groupnorm/device/multi_core/groupnorm_op_multi_core.cpp
Outdated
Show resolved
Hide resolved
...ations/experimental/transformer/rotary_embedding/device/rotary_embedding_program_factory.cpp
Outdated
Show resolved
Hide resolved
...h/moreh_layer_norm_backward/device/moreh_layer_norm_backward_input_grad_device_operation.hpp
Outdated
Show resolved
Hide resolved
tests/tt_metal/tt_metal/unit_tests_common/common/common_fixture.hpp
Outdated
Show resolved
Hide resolved
...imental/transformer/rotary_embedding_llama/device/rotary_embedding_llama_program_factory.cpp
Outdated
Show resolved
Hide resolved
ttnn/cpp/ttnn/operations/eltwise/binary/device/broadcast_width_multi_core_program_factory.cpp
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clang-Tidy
found issue(s) with the introduced code (7/8)
tests/tt_metal/tt_metal/unit_tests/common/core_coord_fixture.hpp
Outdated
Show resolved
Hide resolved
ttnn/cpp/ttnn/operations/moreh/moreh_sgd/device/moreh_sgd_device_operation.hpp
Outdated
Show resolved
Hide resolved
tests/tt_metal/tt_metal/unit_tests_common/common/common_fixture.hpp
Outdated
Show resolved
Hide resolved
tests/tt_metal/tt_metal/unit_tests_common/common/common_fixture.hpp
Outdated
Show resolved
Hide resolved
ttnn/cpp/ttnn/operations/experimental/ccl/all_reduce/device/all_reduce_op.cpp
Outdated
Show resolved
Hide resolved
...eh_layer_norm_backward/device/moreh_layer_norm_backward_gamma_beta_grad_device_operation.hpp
Outdated
Show resolved
Hide resolved
ttnn/cpp/ttnn/operations/moreh/moreh_sum/device/moreh_sum_device_operation.hpp
Outdated
Show resolved
Hide resolved
...n/operations/moreh/moreh_softmax_backward/device/moreh_softmax_backward_device_operation.hpp
Outdated
Show resolved
Hide resolved
ttnn/cpp/ttnn/operations/moreh/moreh_dot/device/moreh_dot_device_operation.hpp
Outdated
Show resolved
Hide resolved
...n/operations/eltwise/binary/device/broadcast_height_and_width_multi_core_program_factory.cpp
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clang-Tidy
found issue(s) with the introduced code (8/8)
ttnn/cpp/ttnn/operations/uniform/device/uniform_device_operation.hpp
Outdated
Show resolved
Hide resolved
35371ee
to
144f32e
Compare
144f32e
to
7a240c9
Compare
7a240c9
to
b958940
Compare
171b3cb
to
3318c40
Compare
5ba8c8e
to
4a1ffc0
Compare
4a1ffc0
to
aa90c2a
Compare
aa90c2a
to
cec0440
Compare
|
||
# TTNN project | ||
- name: Checkout cpp-ttnn-project-template | ||
uses: actions/checkout@v3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any reason to use v3?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oversight.
Ticket
None
Problem description
Making changes to CMake. Don't want to manually audit compatibility. Now it's a click away.
What's changed
New run-it-yourself workflow. It can pass (after tenstorrent/cpp-ttnn-project-template#3 goes it to fix it): https://github.com/tenstorrent/tt-metal/actions/runs/11605407955/job/32315761838
Checklist