Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#0: Workflow to test compatibility with TTNN Project Template #14442

Merged
merged 1 commit into from
Oct 31, 2024

Conversation

afuller-TT
Copy link
Contributor

@afuller-TT afuller-TT commented Oct 29, 2024

Ticket

None

Problem description

Making changes to CMake. Don't want to manually audit compatibility. Now it's a click away.

What's changed

New run-it-yourself workflow. It can pass (after tenstorrent/cpp-ttnn-project-template#3 goes it to fix it): https://github.com/tenstorrent/tt-metal/actions/runs/11605407955/job/32315761838

Checklist

  • Post commit CI passes
  • Blackhole Post commit (if applicable)
  • Model regression CI testing passes (if applicable)
  • Device performance regression CI testing passes (if applicable)
  • New/Existing tests provide coverage for changes

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Clang-Tidy found issue(s) with the introduced code (1/8)

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Clang-Tidy found issue(s) with the introduced code (2/8)

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Clang-Tidy found issue(s) with the introduced code (3/8)

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Clang-Tidy found issue(s) with the introduced code (4/8)

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Clang-Tidy found issue(s) with the introduced code (5/8)

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Clang-Tidy found issue(s) with the introduced code (6/8)

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Clang-Tidy found issue(s) with the introduced code (7/8)

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Clang-Tidy found issue(s) with the introduced code (8/8)

@afuller-TT afuller-TT force-pushed the afuller/cpp-ttnn-project-test branch 5 times, most recently from 5ba8c8e to 4a1ffc0 Compare October 31, 2024 04:38
@afuller-TT afuller-TT marked this pull request as ready for review October 31, 2024 04:41
@afuller-TT afuller-TT force-pushed the afuller/cpp-ttnn-project-test branch from 4a1ffc0 to aa90c2a Compare October 31, 2024 04:41
@afuller-TT afuller-TT force-pushed the afuller/cpp-ttnn-project-test branch from aa90c2a to cec0440 Compare October 31, 2024 17:42
@afuller-TT afuller-TT merged commit bd62962 into main Oct 31, 2024
8 checks passed
@afuller-TT afuller-TT deleted the afuller/cpp-ttnn-project-test branch October 31, 2024 17:44

# TTNN project
- name: Checkout cpp-ttnn-project-template
uses: actions/checkout@v3
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason to use v3?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oversight.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants