#596: Refactor common_runtime_address_map - move PROFILER constants #13783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blozano-tt
requested review from
mo-tenstorrent,
abhullar-tt,
pgkeller,
aliuTT,
tt-aho,
tt-dma,
tt-asaigal and
ubcheema
as code owners
blozano-tt
force-pushed
the
blozano/mv_prof_code
branch
from
ee16e09 to
0c410ff
Compare
abhullar-tt
approved these changes
Oct 15, 2024
|
Thanks for this. Could you run |
mo-tenstorrent
approved these changes
Oct 15, 2024
blozano-tt
force-pushed
the
blozano/mv_prof_code
branch
from
0c410ff to
2cf7034
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -58,3 +58,9 @@ namespace kernel_profiler{ | |||
| constexpr static std::uint32_t PROFILER_L1_BUFFER_SIZE = PROFILER_L1_VECTOR_SIZE * sizeof(uint32_t); | |||
There was a problem hiding this comment.
use of undeclared identifier std
| @@ -58,3 +58,9 @@ namespace kernel_profiler{ | |||
| constexpr static std::uint32_t PROFILER_L1_BUFFER_SIZE = PROFILER_L1_VECTOR_SIZE * sizeof(uint32_t); | |||
There was a problem hiding this comment.
use of undeclared identifier uint32_t
| @@ -58,3 +58,9 @@ namespace kernel_profiler{ | |||
| constexpr static std::uint32_t PROFILER_L1_BUFFER_SIZE = PROFILER_L1_VECTOR_SIZE * sizeof(uint32_t); | |||
|
|
|||
| } | |||
|
|
|||
| constexpr static std::uint32_t PROFILER_OP_SUPPORT_COUNT = 1000; | |||
There was a problem hiding this comment.
use of undeclared identifier std
| @@ -58,3 +58,9 @@ namespace kernel_profiler{ | |||
| constexpr static std::uint32_t PROFILER_L1_BUFFER_SIZE = PROFILER_L1_VECTOR_SIZE * sizeof(uint32_t); | |||
|
|
|||
| } | |||
|
|
|||
| constexpr static std::uint32_t PROFILER_OP_SUPPORT_COUNT = 1000; | |||
| constexpr static std::uint32_t PROFILER_FULL_HOST_VECTOR_SIZE_PER_RISC = kernel_profiler::PROFILER_L1_MARKER_UINT32_SIZE * (kernel_profiler::PROFILER_L1_PROGRAM_ID_COUNT + kernel_profiler::PROFILER_L1_GUARANTEED_MARKER_COUNT + kernel_profiler::PROFILER_L1_OP_MIN_OPTIONAL_MARKER_COUNT) * PROFILER_OP_SUPPORT_COUNT; | |||
There was a problem hiding this comment.
use of undeclared identifier std
|
|
||
| constexpr static std::uint32_t PROFILER_OP_SUPPORT_COUNT = 1000; | ||
| constexpr static std::uint32_t PROFILER_FULL_HOST_VECTOR_SIZE_PER_RISC = kernel_profiler::PROFILER_L1_MARKER_UINT32_SIZE * (kernel_profiler::PROFILER_L1_PROGRAM_ID_COUNT + kernel_profiler::PROFILER_L1_GUARANTEED_MARKER_COUNT + kernel_profiler::PROFILER_L1_OP_MIN_OPTIONAL_MARKER_COUNT) * PROFILER_OP_SUPPORT_COUNT; | ||
| constexpr static std::uint32_t PROFILER_FULL_HOST_BUFFER_SIZE_PER_RISC = PROFILER_FULL_HOST_VECTOR_SIZE_PER_RISC * sizeof(uint32_t); |
There was a problem hiding this comment.
use of undeclared identifier std
|
|
||
| constexpr static std::uint32_t PROFILER_OP_SUPPORT_COUNT = 1000; | ||
| constexpr static std::uint32_t PROFILER_FULL_HOST_VECTOR_SIZE_PER_RISC = kernel_profiler::PROFILER_L1_MARKER_UINT32_SIZE * (kernel_profiler::PROFILER_L1_PROGRAM_ID_COUNT + kernel_profiler::PROFILER_L1_GUARANTEED_MARKER_COUNT + kernel_profiler::PROFILER_L1_OP_MIN_OPTIONAL_MARKER_COUNT) * PROFILER_OP_SUPPORT_COUNT; | ||
| constexpr static std::uint32_t PROFILER_FULL_HOST_BUFFER_SIZE_PER_RISC = PROFILER_FULL_HOST_VECTOR_SIZE_PER_RISC * sizeof(uint32_t); |
There was a problem hiding this comment.
use of undeclared identifier uint32_t
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
#596
#11830
Problem description
We are trying to eliminate common_runtime_address_map, as it is not truly common.
It is a function of ARCH_NAME.
These constants were previously flagged as being in the wrong place.
Moving them to profiler_common.h is a simple solution to rehoming them.
What's changed
Move profiler related constants from
common_runtime_address_maptoprofiler_commonheader file.Checklist
https://github.com/tenstorrent/tt-metal/actions/runs/11336447989