#13656: Deprecate support for mutating program after initial compilation on any device #13684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tt-aho
requested review from
abhullar-tt,
pgkeller,
aliuTT,
tt-dma,
tt-asaigal and
ubcheema
as code owners
tt-aho
force-pushed
the
aho/mutable-program
branch
from
b690fbb to
a11f11f
Compare
aliuTT
approved these changes
Oct 10, 2024
abhullar-tt
approved these changes
Oct 10, 2024
tt-aho
force-pushed
the
aho/mutable-program
branch
from
a11f11f to
e3b4cbc
Compare
…ion on any device
tt-aho
force-pushed
the
aho/mutable-program
branch
from
e3b4cbc to
6eef86b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
#13656
Problem description
We used to support mutating programs after initial compilation (adding kernels, cbs, sems) and would trigger a recompile if this was done. FD changes related to generating needed state/caching data is not regenerated in this case and would be stale, so support for this was now bugged. There doesn't seem to be any use cases for this so we decided to deprecate support for this instead of tracking a dirty flag to regenerate FD state.
What's changed
Deprecate support for mutating programs after initial compilation. Assert out if user attempts to do so.
Checklist