#0: remove device arg from maxpool2d #13615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mywoodstock
force-pushed
the
asarje/maxpool-nodevice
branch
from
b335ee8 to
82ba7a5
Compare
mywoodstock
requested review from
esmalTT,
uaydonat,
shwetankTT,
tt-aho,
tt-rkim,
ayerofieiev-tt,
dmakoviichuk-tt,
rfurko-tt,
cfjchu,
TT-BrianLiu,
razorback3 and
dongjin-na
as code owners
mywoodstock
requested review from
sankarmanoj-tt and
pavlejosipovic
as code owners
tt-aho
approved these changes
Oct 9, 2024
esmalTT
approved these changes
Oct 10, 2024
pavlejosipovic
approved these changes
Oct 10, 2024
tt-rkim
requested changes
Oct 10, 2024
mywoodstock
force-pushed
the
asarje/maxpool-nodevice
branch
2 times, most recently
from
821cffa to
1059ed3
Compare
tt-rkim
approved these changes
Oct 10, 2024
|
awesome , hope no pipes break lol i hate these kinds of changes, you never know what'll happen |
ayerofieiev-tt
approved these changes
Oct 10, 2024
mywoodstock
force-pushed
the
asarje/maxpool-nodevice
branch
from
1059ed3 to
edce406
Compare
cfjchu
reviewed
Oct 10, 2024
| @@ -43,7 +42,7 @@ Tensor MaxPool2DOp::invoke(uint8_t queue_id, const Tensor& input_tensor, uint32_ | |||
| output_shape[1], | |||
| output_shape[2], | |||
| 0, // out_channels -- not used | |||
| device, | |||
| input_tensor.device(), | |||
There was a problem hiding this comment.
I'm a little bit suspicious about this change.. did the T3000/TG tests pass?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
Link to Github Issue
Problem description
Provide context for the problem.
What's changed
Describe the approach used to solve the problem.
Summarize the changes made and its impact.
Checklist