Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#0: untilize tensor on device #12001

Closed
wants to merge 1 commit into from
Closed

#0: untilize tensor on device #12001

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions ttnn/ttnn/operations/core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -309,12 +309,12 @@ def to_torch(
tensor([[-0.3008, -0.8438, 0.3242],
[ 0.9023, -0.5820, 0.5312]], dtype=torch.bfloat16)
"""
if tensor.layout != ttnn.ROW_MAJOR_LAYOUT:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we convert to row-major on-device before moving it from device because it activates untilize on device by default?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are there differences in the output between untilize on host vs. device or is it negligible?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if there are changes, we might want to consider adding a toggleable option for switching between host vs. device untilizer

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is a perf hit for utilizing on host vs device. Adding this as a toggleable option is a good idea

tensor = ttnn.to_layout(tensor, ttnn.ROW_MAJOR_LAYOUT)

if ttnn.is_tensor_storage_on_device(tensor):
tensor = ttnn.from_device(tensor, cq_id=cq_id)

if tensor.layout != ttnn.ROW_MAJOR_LAYOUT:
tensor = tensor.to(ttnn.ROW_MAJOR_LAYOUT, device)

shape_without_tile_padding = tuple(tensor.shape)
if tensor.storage_type() == ttnn.DEVICE_STORAGE_TYPE:
raise RuntimeError("ttnn.Tensor cannot be on device when converting to torch.Tensor!")
Expand Down
Loading