Migrate CBs and Sems to kernel config ring buffer #11595
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pgkeller
requested review from
aliuTT,
ubcheema,
rtawfik01,
rdjogoTT,
ttmtrajkovic,
abhullar-tt,
tt-aho,
tt-dma,
tt-asaigal,
davorchap and
cfjchu
as code owners
| @@ -52,7 +52,7 @@ | |||
| #define MEM_BOOT_CODE_BASE 0 | |||
| #define MEM_L1_BARRIER 12 | |||
| #define MEM_MAILBOX_BASE 16 | |||
| #define MEM_MAILBOX_END (MEM_MAILBOX_BASE + 1344) | |||
| #define MEM_MAILBOX_END (MEM_MAILBOX_BASE + 1348) | |||
There was a problem hiding this comment.
how do we calculate this value? Could you add comment or make it depend on sum of other defines directly?
aliuTT
approved these changes
Aug 19, 2024
abhullar-tt
approved these changes
Aug 19, 2024
| uint32_t tt_l1_ptr *cb_l1_base = (uint32_t tt_l1_ptr *)(kernel_config_base + | ||
| mailboxes->launch.kernel_config.cb_offset); | ||
| setup_cb_read_write_interfaces(cb_l1_base, 0, mailboxes->launch.kernel_config.max_cb_index, cb_init_read, cb_init_write, cb_init_write); | ||
| #if defined(UCK_CHLKC_UNPACK) |
There was a problem hiding this comment.
Can you add a comment about why this delay was added with the issue link?
tt-aho
approved these changes
Aug 19, 2024
Only include ierisc when needed, sometimes the values are 0
Dispatcher is out of memory on ncrisc, disabling for now
Removing the uneeded CB config inits sped up unpacker exposing an as yet unknown timing issue. This delay mimics the delay of the CB config inits to keep tests passing
Trisc FW initializes CBs, this we being done again in llks, removed
pgkeller
force-pushed
the
pkeller/memmap-again
branch
from
b914a55 to
20018c7
Compare
|
Closing. Semaphore change ran into major issues w/ T3k tests, fixed in a separate branch, will pull those in isolation then rebase the rest of this work on that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
#4984
Problem description
Migration of sems and cb configs to ring buffer
What's changed
Move semaphores and CB configs to ring buffer.
Had to hack disable code in cq_dispatch due to code issues
Had to hack around race in llks (this code sped things up exposing a race, added a delay to compensate)
Checklist