Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix sfpi-rel to not use LFS #14590

Closed
pgkeller opened this issue Nov 1, 2024 · 3 comments
Closed

fix sfpi-rel to not use LFS #14590

pgkeller opened this issue Nov 1, 2024 · 3 comments
Assignees
@nathan-TT

Comments

@pgkeller
Copy link
Contributor

pgkeller commented Nov 1, 2024

build w/ a release tarball
nathan-TT added a commit that referenced this issue Nov 5, 2024
@nathan-TT
#14590: Move sfpi off LFS
b34d9b7 
Remove tt_metal/third_party/sfpi submodule.
Add smarts to tt_metal/hw to download sfpi release into runtome/sfpi
@nathan-TT nathan-TT mentioned this issue Nov 5, 2024
Merged
4 tasks
tt-rkim pushed a commit that referenced this issue Nov 8, 2024
@nathan-TT @tt-rkim
#14590: Move sfpi off LFS
ab82ec5 
Remove tt_metal/third_party/sfpi submodule.
Add smarts to tt_metal/hw to download sfpi release into runtome/sfpi
nathan-TT added a commit that referenced this issue Nov 15, 2024
@nathan-TT @tt-rkim
#14590: Move sfpi off LFS (#14758)
42035c1 
Remove tt_metal/third_party/sfpi submodule.
Add smarts to tt_metal/hw to download sfpi release into runtome/sfpi

### Ticket
#14590

### Problem description
LFS bad, don't use it.

### What's changed
New reorg and release mechanism for sfpi -- see 
tenstorrent/sfpi#24

Remove tt_metal/third_party/sfpi submodule
Add smarts to tt_metal/hw to lazily fetch a specific sfpi release (this
patch names v0.0.0-lfsectomy, once we're set I'll create v12.0.0 --
numbering them after the GCC major/minor version numbering and use the
micro number for our own updates.

### Checklist
- [YES] Post commit CI passes
- [ ] Blackhole Post commit (if applicable)
- [ ] Model regression CI testing passes (if applicable)
- [ ] Device performance regression CI testing passes (if applicable)
- [ ] New/Existing tests provide coverage for changes

---------

Co-authored-by: Raymond Kim <[email protected]>
@nathan-TT
Copy link
Contributor

sfpi is now released via tarballs, tt-metal uses the new mechanism.

There is at least one other repo (budabackend) still uses the old mechanism

@tt-rkim
Copy link
Collaborator

tt-rkim commented Nov 27, 2024

@ubcheema @TTDRosen do we still house the erisc main in budabackend?

@nathan-TT
Copy link
Contributor

Declaring victory, We can track the budabackend issue separately,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nathan-TT nathan-TT

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tt-rkim @pgkeller @nathan-TT