#14590: Move sfpi off LFS

Remove tt_metal/third_party/sfpi submodule.
Add smarts to tt_metal/hw to download sfpi release into runtome/sfpi

.gitmodules

@@ -1,6 +1,3 @@
-[submodule "src/ckernels/sfpi"]
-	path = tt_metal/third_party/sfpi
-	url = https://github.com/tenstorrent-metal/sfpi-rel-temp.git
 [submodule "third_party/pybind11"]
 	path = tt_metal/third_party/pybind11
 	url = https://github.com/pybind/pybind11.git

tt_metal/hw/CMakeLists.txt

@@ -18,6 +18,15 @@ set(TYPES
     kernel
 )
 
+add_custom_target(
+    sfpi
+    ${CMAKE_CURRENT_SOURCE_DIR}/sfpi.sh ${CMAKE_CURRENT_SOURCE_DIR}/sfpi.version ${CMAKE_CURRENT_SOURCE_DIR}/sfpi.md5
+    ${PROJECT_SOURCE_DIR}/runtime/sfpi
+    DEPENDS
+        ${CMAKE_CURRENT_SOURCE_DIR}/sfpi.version
+    USES_TERMINAL
+)
+
 foreach(ARCH IN LISTS ARCHS)
     set(DEV_MEM_MAP "${PROJECT_SOURCE_DIR}/tt_metal/hw/inc/${ARCH}/dev_mem_map.h")
     set(HW_INCLUDES "${PROJECT_SOURCE_DIR}/tt_metal/hw/inc/${ARCH}")
@@ -78,7 +87,7 @@ function(get_alias INPUT_STRING OUTPUT_VAR)
 endfunction()
 
 # Define the compiler command
-set(GPP_CMD ${PROJECT_SOURCE_DIR}/tt_metal/third_party/sfpi/compiler/bin/riscv32-unknown-elf-g++)
+set(GPP_CMD ${PROJECT_SOURCE_DIR}/runtime/sfpi/compiler/bin/riscv32-unknown-elf-g++)
 
 set(GPP_DEFINES -DTENSIX_FIRMWARE)
 
@@ -189,6 +198,7 @@ foreach(ARCH IN LISTS ARCHS)
                 ${GPP_CMD} ${GPP_FLAGS} ${GPP_DEFINES} ${GPP_INCLUDES} -c -o ${HW_LIB_DIR}/${HWLIB}.o ${${HWLIB}_SOURCE}
             DEPENDS
                 ${${HWLIB}_SOURCE}
+                sfpi
             COMMENT "Building hw lib ${HWLIB}.o"
             VERBATIM
         )

tt_metal/hw/sfpi.md5

@@ -0,0 +1 @@
+3ffa5a871a6289f19617de7293c1dac0  sfpi-release.tgz

tt_metal/hw/sfpi.sh

@@ -0,0 +1,50 @@
+#! /bin/bash
+
+# Script to automatically get a specified release.  Invoke from your build system providing:
+# VERSION file containing desired version
+# MD5 file containing md5sum checksum
+# DST target directory
+# The script is lazy and will not redownload an already-downloaded version
+
+set -eo pipefail
+
+if [[ "$#" != 3 ]] ; then
+    echo "Usage: $0 VERSIONFILE MD5FILE DSTDIR" 1>&2
+    exit 1
+fi
+
+verfile="$1"
+md5file="$2"
+dstdir="${3%/sfpi}"
+
+if cmp -s "$verfile" "$dstdir/sfpi/sfpi.version" ; then
+    # We have this already
+    touch "$dstdir/sfpi/sfpi.version"
+    echo "Already have sfpi release $(cat "$verfile")"
+    exit 0
+fi
+
+if which curl >/dev/null ; then
+    fetcher="curl -L -o - --ftp-pasv --retry 10"
+elif which wget > /dev/null ; then
+    fetcher="wget -O -"
+else
+    echo "No downloader available" 1>&2
+    exit 1
+fi
+
+url=https://github.com/tenstorrent/sfpi/releases/download
+read hash tarball < "$md5file"
+read ver < "$verfile"
+
+echo "Downloading new sfpi release: $ver/$tarball"
+mkdir -p "$dstdir"
+$fetcher "$url/$ver/$tarball" > "$dstdir/$tarball"
+if ! (cd "$dstdir" ; md5sum -c -) < "$md5file" ; then
+    echo "MD5 hash mismatch on $dstdir/$tarball" 1>&2
+    exit 1
+fi
+
+(cd "$dstdir" && rm -rf sfpi && tar xzf "$tarball")
+echo "$ver" > "$dstdir/sfpi/sfpi.version"
+rm -f "$dstdir/$tarball"

tt_metal/hw/sfpi.version

@@ -0,0 +1 @@
+v0.0.0-lfsectomy

tt_metal/jit_build/build.cpp

@@ -53,7 +53,7 @@ void JitBuildEnv::init(uint32_t build_key, tt::ARCH arch) {
     this->out_kernel_root_ = this->out_root_ + to_string(build_key) + "/kernels/";
 
     // Tools
-    this->gpp_ = this->root_ + "tt_metal/third_party/sfpi/compiler/bin/riscv32-unknown-elf-g++ ";
+    this->gpp_ = this->root_ + "runtime/sfpi/compiler/bin/riscv32-unknown-elf-g++ ";
 
     // Flags
     string common_flags;
@@ -291,8 +291,8 @@ JitBuildCompute::JitBuildCompute(const JitBuildEnv& env, const JitBuiltStateConf
                       env_.root_ + "tt_metal/hw/ckernels/" + env.arch_name_ + "/metal/common " + "-I" + env_.root_ +
                       "tt_metal/hw/ckernels/" + env.arch_name_ + "/metal/llk_io " + "-I" + env_.root_ +
                       "tt_metal/hw/ckernels/" + env.arch_name_ + "/metal/llk_api " + "-I" + env_.root_ +
-                      "tt_metal/hw/ckernels/" + env.arch_name_ + "/metal/llk_api/llk_sfpu " + "-I" + env_.root_ +
-                      "tt_metal/third_party/sfpi/include " + "-I" + env_.root_ + "tt_metal/hw/firmware/src " + "-I" +
+                      "tt_metal/hw/ckernels/" + env.arch_name_ + "/metal/llk_api/llk_sfpu " + "-I" +
+                      env_.root_ + "runtime/sfpi/include " + "-I" + env_.root_ + "tt_metal/hw/firmware/src " + "-I" +
                       env_.root_ + "tt_metal/third_party/tt_llk_" + env.arch_name_ + "/llk_lib ";
 
     if (this->is_fw_) {