-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove remaining pieces of common_runtime_address_map #11830
Comments
See #13785 for export of MEM_MAP_END |
@pgkeller so the NOC_0* macros should become Hal class methods, correct? |
funny, those macros are misnamed (NOC_0 but take noc_index as a parameter). |
The two macros are also redundant. They execute the same compute. |
@abhullar-tt sorry, I accidentally closed this. It is not completely done, but there are no more components here that block ARCH_NAME removal. I think the file is only included behind the Hal. |
Once the profiler code is removed from the common_runtime_addressmap, the rest can be removed as well:
Marking P1 because with this done we have an easy path to larger buffers for eth dispatch
The text was updated successfully, but these errors were encountered: