Skip to content

Commit

Permalink
wip
Browse files Browse the repository at this point in the history
  • Loading branch information
cfjchu committed Feb 21, 2025
1 parent f8193f9 commit cc5f8ad
Show file tree
Hide file tree
Showing 5 changed files with 5 additions and 2 deletions.
1 change: 0 additions & 1 deletion tests/ttnn/unit_tests/test_multi_device.py
Original file line number Diff line number Diff line change
Expand Up @@ -578,7 +578,6 @@ def test_slicing(mesh_device):


def test_clone(mesh_device):
pytest.skip("TT-Mesh: logic in clone needs to be fixed: fails with Not implemented")
results_11BH = ttnn.from_torch(
torch.randn(1, 1, 32, 128),
dtype=ttnn.bfloat16,
Expand Down
1 change: 1 addition & 0 deletions tt_metal/api/tt-metalium/mesh_device_view.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,7 @@ class MeshDeviceView {
[[nodiscard]] DeviceView get_devices(const SimpleMeshShape& submesh_shape) const;
[[nodiscard]] DeviceView get_devices() const;
[[nodiscard]] size_t num_devices() const;
[[nodiscard]] const MeshCoordinateRange& coord_range() const;

[[nodiscard]] bool empty() const noexcept;
[[nodiscard]] size_t size() const noexcept;
Expand Down
2 changes: 2 additions & 0 deletions tt_metal/distributed/mesh_device_view.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -119,6 +119,8 @@ size_t MeshDeviceView::num_cols() const {
}
size_t MeshDeviceView::num_devices() const { return devices_.shape().mesh_size(); }

const MeshCoordinateRange& MeshDeviceView::coord_range() const { return devices_.coord_range(); }

bool MeshDeviceView::contains_device(chip_id_t device_id) const {
return device_coordinates_.find(device_id) != device_coordinates_.end();
}
Expand Down
1 change: 1 addition & 0 deletions ttnn/cpp/ttnn/device_operation.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -293,6 +293,7 @@ void launch_on_worker_thread(auto cq_id, auto device_operation_id, const auto& o
};

if (is_program_cache_enabled) {
TT_THROW("Program cache not yet supported");
auto& program = create_or_get_program_from_cache<device_operation_t>(
program_cache, program_cache_hit, program_hash, operation_attributes, tensor_args, tensor_return_value);

Expand Down
2 changes: 1 addition & 1 deletion ttnn/cpp/ttnn/tensor/storage.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
namespace tt::tt_metal {

DeviceStorage::DeviceStorage(std::shared_ptr<Buffer> buffer_) {
TT_THROW("DeviceStorage not implemented for Buffer");
tt::log_warning("Constructing DeviceStorage from Single-Device Buffer");
buffer = std::move(buffer_);
}

Expand Down

0 comments on commit cc5f8ad

Please sign in to comment.