Skip to content

Commit

Permalink
#11135: Provide device_info as a dictionary value containing device…
Browse files Browse the repository at this point in the history
… info in environment.csv in a benchmark run (#11141)

* #11135: Rip out device_type and device_memory_size into device_info dict in environment.csv

* #11135: Fix given column names
  • Loading branch information
tt-rkim authored Aug 7, 2024
1 parent 6aa8e15 commit 9bb4ee1
Showing 1 changed file with 9 additions and 4 deletions.
13 changes: 9 additions & 4 deletions infra/data_collection/github/utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -51,8 +51,7 @@
"docker_image",
"device_hostname",
"device_ip",
"device_type",
"device_memory_size",
"device_info",
)


Expand Down Expand Up @@ -327,6 +326,13 @@ def create_csv_for_github_benchmark_environment(github_benchmark_environment_csv
logger.warning("Hardcoded null for device_memory_size")
device_memory_size = ""

device_info = json.dumps(
{
"device_type": device_type,
"device_memory_size": device_memory_size,
}
)

benchmark_environment_row = {
"git_repo_name": git_repo_name,
"git_commit_hash": git_commit_hash,
Expand All @@ -337,8 +343,7 @@ def create_csv_for_github_benchmark_environment(github_benchmark_environment_csv
"docker_image": docker_image,
"device_hostname": device_hostname,
"device_ip": device_ip,
"device_type": device_type,
"device_memory_size": device_memory_size,
"device_info": device_info,
}

create_csv(github_benchmark_environment_csv_filename, BENCHMARK_ENVIRONMENT_CSV_FIELDS, [benchmark_environment_row])

0 comments on commit 9bb4ee1

Please sign in to comment.