Skip to content

Commit

Permalink
#14112: Remove old ttnn_sweeps results docs build because no one uses…
Browse files Browse the repository at this point in the history
… it and it's flaky because it tries to grab the latest result so it's not a deterministic build (#14153)
  • Loading branch information
tt-rkim authored Oct 23, 2024
1 parent f307141 commit 0d3fb48
Show file tree
Hide file tree
Showing 7 changed files with 1 addition and 516 deletions.
6 changes: 1 addition & 5 deletions docs/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -15,14 +15,13 @@ PORT ?= 8888
DOCS_VERSION ?= latest

GITHUB_TOKEN ?= INSERT_TOKEN_HERE
TTNN_SWEEPS_DIR = source/ttnn/ttnn_sweeps
TTNN_API_DIR = source/ttnn/ttnn/api

# Put it first so that "make" without argument is like "make help".
help:
@$(SPHINXBUILD) -M help "$(SOURCEDIR)" "$(BUILDDIR)" $(SPHINXOPTS) $(O)

.PHONY: help default clean html publish build_doxygen sphinx_build_dir html/ttnn html/tt-metalium ttnn_sweeps
.PHONY: help default clean html publish build_doxygen sphinx_build_dir html/ttnn html/tt-metalium

default: html

Expand Down Expand Up @@ -51,9 +50,6 @@ html: html/tt-metalium html/ttnn
mv -f $(TTNN_BUILDDIR) $(HTMLDIR)/ttnn
cp source/index.html $(HTMLDIR)/

ttnn_sweeps:
@echo "Note that GITHUB_TOKEN must be set before calling this"
@cd .. && python tests/ttnn/sweep_tests/build_rst_sweep_results.py --dir docs/$(TTNN_SWEEPS_DIR) --token $(GITHUB_TOKEN)

server:
@echo "Navigate to: \033[4;33mlocalhost:$(PORT)/index.html\033[0m"
Expand Down
1 change: 0 additions & 1 deletion docs/source/ttnn/index.rst
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ Welcome to TT-NN documentation!
ttnn/profiling_ttnn_operations
ttnn/dependencies/index.rst
ttnn/demos
ttnn_sweeps/index.rst

.. toctree::
:caption: Models
Expand Down
1 change: 0 additions & 1 deletion docs/source/ttnn/ttnn/onboarding.rst
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ is that the long term benefits will help us maintain our objectives. Please foll
* When creating the branch, please follow the pattern of 'TTNN-<Issue Number>-<brief description>'. For example, if the issue is 4730, the branch name would be `TTNN-4730-concat-operation`
* Use the `fallback` reference implementation for the operation and implement the functionality.
* Add the documentation in the rst format for the operation under `ttnn documentation <https://github.com/tenstorrent/tt-metal/tree/main/docs/source/ttnn/ttnn>`_
* Add :ref:`sweep tests<ttnn.sweep_tests>` to the branch using the fallback implementation under `ttnn sweep tests <https://github.com/tenstorrent/tt-metal/tree/main/tests/ttnn/sweep_tests/sweeps>`_
3. Update the issue referencing the pull requests after verifying that all the sweep tests run as expected. A TTNN CODEOWNERS will review the PR and verify that the API is acceptable and that the sweep tests reflect the intended functionality.
4. If the pull request (PR) is accepted it will be merge into the main branch and a new branch should be created that adds the implementation.
* The fallback implementation for the Operation should be left and will continue to be used for op-by-op PCC comparisons when debugging models (see `--ttnn-enable-debug-decorator`).
Expand Down
6 changes: 0 additions & 6 deletions docs/source/ttnn/ttnn_sweeps/index.rst

This file was deleted.

1 change: 0 additions & 1 deletion tests/scripts/run_build_docs.sh
Original file line number Diff line number Diff line change
Expand Up @@ -11,5 +11,4 @@ echo "Checking docs build..."
cd $TT_METAL_HOME/docs
python -m pip install -r requirements-docs.txt
make clean
make ttnn_sweeps
make html
202 changes: 0 additions & 202 deletions tests/ttnn/sweep_tests/build_html_sweep_results.py

This file was deleted.

Loading

0 comments on commit 0d3fb48

Please sign in to comment.