Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Logging Utils #39

Merged
merged 7 commits into from
Nov 19, 2024
Merged

Add Logging Utils #39

merged 7 commits into from
Nov 19, 2024

Conversation

mvanniasingheTT
Copy link
Contributor

@mvanniasingheTT mvanniasingheTT commented Nov 18, 2024

Adding Logging

This PR adds logging functionality to the online and offline mock models as well as to the vllm api server. Note there was a previous PR with the same changes but this PR is rebased off main and has a cleaner commit history.

Note:

There is some repeated code from logging_utils.py in mock_vllm_model.py since usage of these functions and classes in the online and offline mock model inference scripts and requires refactoring of the tt-inference-server directory naming. Repeated code can be removed following the refactoring.

Changes

This PR addresses comments from the previous PR such as:

  1. Handling the case where only decode is happening
  2. Using JSONL vs JSON for less overhead
  3. Cleaner patches
  4. Handles the case where not all requests come in at same time for online inference

@mvanniasingheTT mvanniasingheTT force-pushed the mvanniasinghe/logging-rebased branch from 2f6bd64 to 93c912a Compare November 18, 2024 15:53
@mvanniasingheTT mvanniasingheTT force-pushed the mvanniasinghe/logging-rebased branch from 2583311 to c7836ce Compare November 19, 2024 20:55
@mvanniasingheTT mvanniasingheTT merged commit 464073f into main Nov 19, 2024
1 check passed
@mvanniasingheTT mvanniasingheTT deleted the mvanniasinghe/logging-rebased branch December 3, 2024 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants