Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test for embedding op #903

Merged
merged 1 commit into from
Feb 25, 2025
Merged

Test for embedding op #903

merged 1 commit into from
Feb 25, 2025

Conversation

kmilanovicTT
Copy link
Contributor

Test torch embedding operator

Supported operand source models for Forge:

from dram
from host
from another op
const eval pass
mf and df tests

Closes #267

@kmilanovicTT kmilanovicTT added the Ops Support new op in tt-forge and tt-mlir label Dec 12, 2024
@kmilanovicTT kmilanovicTT self-assigned this Dec 12, 2024
@kmilanovicTT kmilanovicTT force-pushed the kmilanovic/pytorch_embedding_op_tests branch 3 times, most recently from 2a6f904 to fe30dcb Compare December 19, 2024 12:02
@kmilanovicTT kmilanovicTT marked this pull request as ready for review December 19, 2024 12:03
@kmilanovicTT kmilanovicTT force-pushed the kmilanovic/pytorch_embedding_op_tests branch 2 times, most recently from ec3e033 to 606acbc Compare December 19, 2024 18:39
@kmilanovicTT kmilanovicTT force-pushed the kmilanovic/pytorch_embedding_op_tests branch 2 times, most recently from 355d30c to ee35a8a Compare December 25, 2024 13:59
@kmilanovicTT kmilanovicTT force-pushed the kmilanovic/pytorch_embedding_op_tests branch from ee35a8a to ea05fb5 Compare January 20, 2025 09:12
@kmilanovicTT
Copy link
Contributor Author

kmilanovicTT commented Jan 20, 2025 •
edited
Loading

Before when testing embedding op with input source: FROM_ANOTHER_OP there were errors:

  • Runtime error: "input_tensor_arg.get_layout() == ttnn::ROW_MAJOR_LAYOUT"

This is fixed but tests with input source: FROM_ANOTHER_OP are now failing with errors:

  • AssertionError: PCC check failed
  • RuntimeError: Fatal error

@github-actions GitHub Actions
Copy link

TestsPassed ✅Skipped ⚠️Failed
TT-Forge-FE Tests665 ran434 passed231 skipped0 failed
TestResult
No test annotations available

@github-actions GitHub Actions
Copy link

TestsPassed ✅Skipped ⚠️Failed
TT-Forge-FE Tests823 ran490 passed333 skipped0 failed
TestResult
No test annotations available

@kmilanovicTT kmilanovicTT force-pushed the kmilanovic/pytorch_embedding_op_tests branch from ea05fb5 to 7b02a2f Compare February 24, 2025 15:48
@github-actions GitHub Actions
Copy link

TestsPassedSkippedFailed ❌️
TT-Forge-FE Tests1 ran0 passed0 skipped1 failed
TestResult
TT-Forge-FE Tests
pytest
test_all.forge.test.operators.pytorch.test_all❌ failure

3 similar comments
@github-actions GitHub Actions
Copy link

TestsPassedSkippedFailed ❌️
TT-Forge-FE Tests1 ran0 passed0 skipped1 failed
TestResult
TT-Forge-FE Tests
pytest
test_all.forge.test.operators.pytorch.test_all❌ failure

@github-actions GitHub Actions
Copy link

TestsPassedSkippedFailed ❌️
TT-Forge-FE Tests1 ran0 passed0 skipped1 failed
TestResult
TT-Forge-FE Tests
pytest
test_all.forge.test.operators.pytorch.test_all❌ failure

@github-actions GitHub Actions
Copy link

TestsPassedSkippedFailed ❌️
TT-Forge-FE Tests1 ran0 passed0 skipped1 failed
TestResult
TT-Forge-FE Tests
pytest
test_all.forge.test.operators.pytorch.test_all❌ failure

@kmilanovicTT kmilanovicTT force-pushed the kmilanovic/pytorch_embedding_op_tests branch 2 times, most recently from 4b99046 to 77566d6 Compare February 24, 2025 16:47
@github-actions GitHub Actions
Copy link

TestsPassed ✅Skipped ⚠️Failed
TT-Forge-FE Tests662 ran525 passed137 skipped0 failed
TestResult
No test annotations available

@github-actions GitHub Actions
Copy link

TestsPassed ✅Skipped ⚠️Failed
TT-Forge-FE Tests604 ran478 passed126 skipped0 failed
TestResult
No test annotations available

1 similar comment
@github-actions GitHub Actions
Copy link

TestsPassed ✅Skipped ⚠️Failed
TT-Forge-FE Tests604 ran478 passed126 skipped0 failed
TestResult
No test annotations available

@github-actions GitHub Actions
Copy link

TestsPassed ✅Skipped ⚠️Failed
TT-Forge-FE Tests662 ran525 passed137 skipped0 failed
TestResult
No test annotations available

@kmilanovicTT kmilanovicTT force-pushed the kmilanovic/pytorch_embedding_op_tests branch from 77566d6 to c9f537b Compare February 25, 2025 12:59
@github-actions GitHub Actions
Copy link

TestsPassed ✅Skipped ⚠️Failed
TT-Forge-FE Tests670 ran536 passed134 skipped0 failed
TestResult
No test annotations available

@github-actions GitHub Actions
Copy link

TestsPassed ✅Skipped ⚠️Failed
TT-Forge-FE Tests611 ran482 passed129 skipped0 failed
TestResult
No test annotations available

@github-actions GitHub Actions
Copy link

TestsPassed ☑️Skipped ⚠️Failed ❌️
TT-Forge-FE Tests611 ran481 passed129 skipped1 failed
TestResult
TT-Forge-FE Tests
pytest
test_dla.test_dla_pytorch[dla34]❌ failure

@github-actions GitHub Actions
Copy link

TestsPassed ✅Skipped ⚠️Failed
TT-Forge-FE Tests670 ran536 passed134 skipped0 failed
TestResult
No test annotations available

@kmilanovicTT kmilanovicTT force-pushed the kmilanovic/pytorch_embedding_op_tests branch from c9f537b to 1941951 Compare February 25, 2025 14:50
@kmilanovicTT kmilanovicTT force-pushed the kmilanovic/pytorch_embedding_op_tests branch from 1941951 to 7e13e43 Compare February 25, 2025 14:52
@github-actions GitHub Actions
Copy link

TestsPassed ✅Skipped ⚠️Failed
TT-Forge-FE Tests611 ran482 passed129 skipped0 failed
TestResult
No test annotations available

@github-actions GitHub Actions
Copy link

TestsPassed ✅Skipped ⚠️Failed
TT-Forge-FE Tests670 ran536 passed134 skipped0 failed
TestResult
No test annotations available

@github-actions GitHub Actions
Copy link

TestsPassed ✅Skipped ⚠️Failed
TT-Forge-FE Tests611 ran482 passed129 skipped0 failed
TestResult
No test annotations available

@github-actions GitHub Actions
Copy link

TestsPassed ✅Skipped ⚠️Failed
TT-Forge-FE Tests670 ran536 passed134 skipped0 failed
TestResult
No test annotations available

@kmilanovicTT kmilanovicTT merged commit 682b974 into main Feb 25, 2025
10 checks passed
@kmilanovicTT kmilanovicTT deleted the kmilanovic/pytorch_embedding_op_tests branch February 25, 2025 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vbrkicTT vbrkicTT vbrkicTT left review comments

@dgolubovicTT dgolubovicTT dgolubovicTT approved these changes

@vobojevicTT vobojevicTT Awaiting requested review from vobojevicTT

@nvukobratTT nvukobratTT Awaiting requested review from nvukobratTT nvukobratTT is a code owner

@pilkicTT pilkicTT Awaiting requested review from pilkicTT pilkicTT is a code owner

Assignees

@kmilanovicTT kmilanovicTT

Labels
Ops Support new op in tt-forge and tt-mlir
Projects
None yet
Milestone
[FFE - E2E] Op testing (sweeps)
Development

Successfully merging this pull request may close these issues.

[Op Testing] Embedding
3 participants
@kmilanovicTT @dgolubovicTT @vbrkicTT