Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ci] add mnist inference test #89

Merged
merged 1 commit into from
Aug 16, 2024
Merged

[ci] add mnist inference test #89

merged 1 commit into from
Aug 16, 2024

Conversation

pilkicTT
Copy link
Contributor

No description provided.

nvukobratTT
nvukobratTT approved these changes Aug 15, 2024
View reviewed changes
Copy link
Contributor

@nvukobratTT nvukobratTT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Once we add a bit more tests, let's think about splitting them into multiple jobs. It'll be nice to get some of these executed in parallel, but also to get a cleaner semantic separation between different test groups.

@pilkicTT
Copy link
Contributor Author

LGTM! Once we add a bit more tests, let's think about splitting them into multiple jobs. It'll be nice to get some of these executed in parallel, but also to get a cleaner semantic separation between different test groups.

Sure, for now let's enjoy the simplicity and ease of running three test files on CI... 😄

@pilkicTT pilkicTT merged commit 8d1b35c into main Aug 16, 2024
3 checks passed
@pilkicTT pilkicTT deleted the pilkic/add-mnist-ci branch August 16, 2024 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nvukobratTT nvukobratTT nvukobratTT approved these changes

@sdjordjevicTT sdjordjevicTT sdjordjevicTT approved these changes

@vmilosevic vmilosevic Awaiting requested review from vmilosevic

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pilkicTT @nvukobratTT @sdjordjevicTT