Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for complex yolov4 model #1318

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Add support for complex yolov4 model #1318

wants to merge 1 commit into from

Conversation

kamalrajkannan78
Copy link
Contributor

@kamalrajkannan78 kamalrajkannan78 commented Feb 25, 2025 •
edited
Loading

Summary

Log

Note:

Priorities:

@kamalrajkannan78 kamalrajkannan78 force-pushed the kkannan/complex_yolov4_bringup_feb25 branch from 3ed2fe7 to 24d525b Compare February 25, 2025 14:17
@kamalrajkannan78 kamalrajkannan78 changed the title complex_yolov4 inference script Add support for complex_yolov4 model Feb 25, 2025
@kamalrajkannan78 kamalrajkannan78 changed the title Add support for complex_yolov4 model Add support for complex yolov4 model Feb 25, 2025
@github-actions GitHub Actions
Copy link

TestsPassed ✅Skipped ⚠️Failed
TT-Forge-FE Tests611 ran482 passed129 skipped0 failed
TestResult
No test annotations available

1 similar comment
@github-actions GitHub Actions
Copy link

TestsPassed ✅Skipped ⚠️Failed
TT-Forge-FE Tests611 ran482 passed129 skipped0 failed
TestResult
No test annotations available

@github-actions GitHub Actions
Copy link

TestsPassed ✅Skipped ⚠️Failed
TT-Forge-FE Tests670 ran536 passed134 skipped0 failed
TestResult
No test annotations available

1 similar comment
@github-actions GitHub Actions
Copy link

TestsPassed ✅Skipped ⚠️Failed
TT-Forge-FE Tests670 ran536 passed134 skipped0 failed
TestResult
No test annotations available

ashokkumarkannan1
ashokkumarkannan1 requested changes Feb 26, 2025
View reviewed changes
forge/test/models/pytorch/vision/complex_yolov4/test_complex_yolov4.py Outdated
model.eval()

# prepare sample input
sample_input = torch.randn((1, 3, 608, 608))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why don't we load any image here? Any reason to go for random inputs?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Due to the size of the dataset , I am unable to figure out a way to pass single input data. that's why I passed random input for now. will figure out a way and will provide the actual input once the model passes end-to-end.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you please raise an issue for the same to address this in future and to make sure we don't miss it?
cc: @nvukobratTT

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#1330

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ashokkumarkannan1 @nvukobratTT

Marked the PR as draft due to the presence of bunch of code from github.

forge/test/models/pytorch/vision/complex_yolov4/test_complex_yolov4.py Outdated
sample_input = torch.randn((1, 3, 608, 608))

# Forge compile framework model
compiled_model = forge.compile(model, sample_inputs=[sample_input], module_name=module_name)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pls add Verify function

forge/test/models/pytorch/vision/complex_yolov4/utils/cal_intersection_rotated_boxes.py
#
# SPDX-License-Identifier: Apache-2.0
"""
# -*- coding: utf-8 -*-
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to wait for @nvukobratTT's inputs, to place this GitHub copied files in a proper place.

forge/test/models/utils.py Outdated
@@ -36,6 +36,7 @@ class Task(StrEnum):
CONDITIONAL_GENERATION = "cond_gen"
IMAGE_ENCODING = "img_enc"
VISUAL_BACKBONE = "visual_bb"
OBJECT_DETECTION_3D = "object_detection_3D"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rename "object_detection_3D" to "object_detection_3d" to follow lowercase.

@kamalrajkannan78 kamalrajkannan78 force-pushed the kkannan/complex_yolov4_bringup_feb25 branch from 24d525b to e27d337 Compare February 26, 2025 09:30
@kamalrajkannan78 kamalrajkannan78 force-pushed the kkannan/complex_yolov4_bringup_feb25 branch from e27d337 to d107322 Compare February 26, 2025 09:40
@kamalrajkannan78 kamalrajkannan78 marked this pull request as ready for review February 26, 2025 10:16
@github-actions GitHub Actions
Copy link

TestsPassed ✅Skipped ⚠️Failed
TT-Forge-FE Tests613 ran481 passed132 skipped0 failed
TestResult
No test annotations available

1 similar comment
@github-actions GitHub Actions
Copy link

TestsPassed ✅Skipped ⚠️Failed
TT-Forge-FE Tests613 ran481 passed132 skipped0 failed
TestResult
No test annotations available

@github-actions GitHub Actions
Copy link

TestsPassed ✅Skipped ⚠️Failed
TT-Forge-FE Tests672 ran536 passed136 skipped0 failed
TestResult
No test annotations available

1 similar comment
@github-actions GitHub Actions
Copy link

TestsPassed ✅Skipped ⚠️Failed
TT-Forge-FE Tests672 ran536 passed136 skipped0 failed
TestResult
No test annotations available

@kamalrajkannan78 kamalrajkannan78 marked this pull request as draft February 26, 2025 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashokkumarkannan1 ashokkumarkannan1 ashokkumarkannan1 requested changes

@vkovinicTT vkovinicTT Awaiting requested review from vkovinicTT vkovinicTT is a code owner

@mstojkovicTT mstojkovicTT Awaiting requested review from mstojkovicTT mstojkovicTT is a code owner

@nvukobratTT nvukobratTT Awaiting requested review from nvukobratTT nvukobratTT is a code owner

@pilkicTT pilkicTT Awaiting requested review from pilkicTT pilkicTT is a code owner

@dgolubovicTT dgolubovicTT Awaiting requested review from dgolubovicTT dgolubovicTT is a code owner

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kamalrajkannan78 @ashokkumarkannan1