-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TVM cleanup #1267
TVM cleanup #1267
Conversation
|
1 similar comment
|
|
1 similar comment
|
c3ec87c
to
a1e1ffb
Compare
a1e1ffb
to
b5899f7
Compare
|
|
|
f0ef8a1
to
06695f3
Compare
|
|
1 similar comment
|
|
ac35cd8
to
5a643fb
Compare
|
|
|
|
5a643fb
to
c0eb533
Compare
|
1 similar comment
|
|
1 similar comment
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. And I agree, we should restructure these once we complete with initial cleanup and uplift.
Also, you have one minor issue with the updated location of construct_pre_node_map
. Issues is rather trivial, so I'm still approving this PR so you can merge it once it's resolved.
Also, make sure to run nightly tests to confirm if there aren't some strange regressions coming out of this change.
c0eb533
to
0a6dc13
Compare
|
1 similar comment
|
|
1 similar comment
|
…ttern (python+cc) files in tvm
5ea2928
to
29a2b45
Compare
I've fixed the problem with |
|
1 similar comment
|
|
1 similar comment
|
Result
Compiler logic moved from
tvm
toforge-fe
.Comprehensive overview
This is only the first cleaning pass where core compiler logic was transfered from tvm to the forge-fe. For comprehensive overview, TVM will be cleaned in a few stages.
Coresponding PR in tvm.
Moved following files to
forge-fe
repo:python/tvm/contrib/forge_compile.py
python/tvm/contrib/forge_utils.py
python/tvm/relay/op/contrib/forge/__init__.py
python/tvm/relay/op/contrib/forge/forge.py
python/tvm/relay/op/contrib/forge/relay_passes.py
python/tvm/relay/op/contrib/forge/reportify.py
python/tvm/relay/op/contrib/forge/utils.py
.Coresponding structure:
**Aditional notes:
These files were just moved to our repo so once uplift is done, we should probably refactor this code into more sensible modules.