Add phi-3-medium model #1235
Draft
Add phi-3-medium model #1235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
||||||||||||||
1 similar comment
|
||||||||||||||
|
||||||||||||||
1 similar comment
|
||||||||||||||
ashokkumarkannan1
requested changes
Feb 19, 2025
There was a problem hiding this comment.
Thanks for the PR @dsudhakarTT . Please address the comments given and update the PR description with relevant details.
|
|
||
|
|
||
| @pytest.mark.parametrize("variant", variants) | ||
| def test_phi3_causal_lm(variant): |
There was a problem hiding this comment.
can we have same test structure followed here?
Pls refer - https://github.com/tenstorrent/tt-forge-fe/blob/main/forge/test/models/pytorch/audio/stereo/test_stereo.py
| framework_model.eval() | ||
| input_prompt = "Africa is an emerging economy because" | ||
| inputs = tokenizer(input_prompt, return_tensors="pt").to("cpu") | ||
| with torch.no_grad(): |
There was a problem hiding this comment.
what happens without with torch.no_grad():
| op = framework_model(inputs["input_ids"], inputs["attention_mask"]) | ||
| logger.info(f"op={op}") | ||
| module_name = build_module_name(variant, Source.HUGGINGFACE, Framework.PYTORCH, Task.CAUSAL_LM) | ||
| compiled_model = forge.compile(framework_model, [inputs["input_ids"], inputs["attention_mask"]], module_name) |
There was a problem hiding this comment.
pls add verify function too
dsudhakarTT
force-pushed
the
dsudhakar/phi-3-medium
branch
from
4ad89ea to
b893bec
Compare
|
||||||||||||||
1 similar comment
|
||||||||||||||
|
||||||||||||||
1 similar comment
|
||||||||||||||
ashokkumarkannan1
requested changes
Feb 26, 2025
| def test_phi3_causal_lm(record_forge_property, variant): | ||
|
|
||
| # Build Module Name | ||
| module_name = build_module_name(variant, Source.HUGGINGFACE, Framework.PYTORCH, Task.CAUSAL_LM) |
There was a problem hiding this comment.
let's update to
# Build Module Name
module_name = build_module_name(
framework=Framework.PYTORCH,
model="phi3",
variant=variant,
task=Task.CAUSAL_LM,
source=Source.HUGGINGFACE,
)| sample_inputs = [inputs["input_ids"], inputs["attention_mask"]] | ||
|
|
||
| # Forge compile framework model | ||
| compiled_model = forge.compile(framework_model, sample_inputs, module_name) |
There was a problem hiding this comment.
pls add verify function
|
|
||
| # Forge compile framework model | ||
| compiled_model = forge.compile(framework_model, inputs, module_name) | ||
|
|
There was a problem hiding this comment.
pls add verify function
| inputs = [inputs["input_ids"]] | ||
|
|
||
| # Forge compile framework model | ||
| compiled_model = forge.compile(framework_model, inputs, module_name) |
There was a problem hiding this comment.
pls add verify function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.