Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add repeat op support from Forge to TTIR Lowering #1214

Merged
merged 1 commit into from
Feb 26, 2025
Merged

Add repeat op support from Forge to TTIR Lowering #1214

merged 1 commit into from
Feb 26, 2025

Conversation

ashokkumarkannan1
Copy link
Contributor

@ashokkumarkannan1 ashokkumarkannan1 commented Feb 13, 2025 •
edited
Loading

Ticket

#1215

Problem description

Add repeat op support from Forge to TTIR Lowering

What's changed

  • Added repeat op support from Forge to TTIR Lowering
  • Added support for DenseI64ArrayAttr TargetType mapping in Repeat op

@github-actions GitHub Actions
Copy link

TestsPassed ✅Skipped ⚠️Failed
TT-Forge-FE Tests593 ran468 passed125 skipped0 failed
TestResult
No test annotations available

1 similar comment
@github-actions GitHub Actions
Copy link

TestsPassed ✅Skipped ⚠️Failed
TT-Forge-FE Tests593 ran468 passed125 skipped0 failed
TestResult
No test annotations available

@github-actions GitHub Actions
Copy link

TestsPassed ✅Skipped ⚠️Failed
TT-Forge-FE Tests652 ran511 passed141 skipped0 failed
TestResult
No test annotations available

1 similar comment
@github-actions GitHub Actions
Copy link

TestsPassed ✅Skipped ⚠️Failed
TT-Forge-FE Tests652 ran511 passed141 skipped0 failed
TestResult
No test annotations available

@ashokkumarkannan1 ashokkumarkannan1 changed the title repeat op support Add repeat op support from Forge to TTIR Lowering Feb 13, 2025
@ashokkumarkannan1 ashokkumarkannan1 force-pushed the akannan/repeat_op_support branch from 27db625 to caa3409 Compare February 13, 2025 07:25
@ashokkumarkannan1 ashokkumarkannan1 marked this pull request as ready for review February 13, 2025 07:29
@github-actions GitHub Actions
Copy link

TestsPassed ✅Skipped ⚠️Failed
TT-Forge-FE Tests593 ran468 passed125 skipped0 failed
TestResult
No test annotations available

1 similar comment
@github-actions GitHub Actions
Copy link

TestsPassed ✅Skipped ⚠️Failed
TT-Forge-FE Tests593 ran468 passed125 skipped0 failed
TestResult
No test annotations available

@github-actions GitHub Actions
Copy link

TestsPassed ✅Skipped ⚠️Failed
TT-Forge-FE Tests652 ran511 passed141 skipped0 failed
TestResult
No test annotations available

1 similar comment
@github-actions GitHub Actions
Copy link

TestsPassed ✅Skipped ⚠️Failed
TT-Forge-FE Tests652 ran511 passed141 skipped0 failed
TestResult
No test annotations available

@ashokkumarkannan1 ashokkumarkannan1 force-pushed the akannan/repeat_op_support branch from caa3409 to dc0922e Compare February 14, 2025 12:10
@github-actions GitHub Actions
Copy link

TestsPassed ✅Skipped ⚠️Failed
TT-Forge-FE Tests604 ran478 passed126 skipped0 failed
TestResult
No test annotations available

1 similar comment
@github-actions GitHub Actions
Copy link

TestsPassed ✅Skipped ⚠️Failed
TT-Forge-FE Tests604 ran478 passed126 skipped0 failed
TestResult
No test annotations available

@github-actions GitHub Actions
Copy link

TestsPassed ✅Skipped ⚠️Failed
TT-Forge-FE Tests662 ran521 passed141 skipped0 failed
TestResult
No test annotations available

2 similar comments
@github-actions GitHub Actions
Copy link

TestsPassed ✅Skipped ⚠️Failed
TT-Forge-FE Tests662 ran521 passed141 skipped0 failed
TestResult
No test annotations available

@github-actions GitHub Actions
Copy link

TestsPassed ✅Skipped ⚠️Failed
TT-Forge-FE Tests662 ran521 passed141 skipped0 failed
TestResult
No test annotations available

@github-actions GitHub Actions
Copy link

TestsPassed ✅Skipped ⚠️Failed
TT-Forge-FE Tests604 ran478 passed126 skipped0 failed
TestResult
No test annotations available

1 similar comment
@github-actions GitHub Actions
Copy link

TestsPassed ✅Skipped ⚠️Failed
TT-Forge-FE Tests604 ran478 passed126 skipped0 failed
TestResult
No test annotations available

@github-actions GitHub Actions
Copy link

TestsPassed ✅Skipped ⚠️Failed
TT-Forge-FE Tests662 ran521 passed141 skipped0 failed
TestResult
No test annotations available

@github-actions GitHub Actions
Copy link

TestsPassed ✅Skipped ⚠️Failed
TT-Forge-FE Tests604 ran480 passed124 skipped0 failed
TestResult
No test annotations available

1 similar comment
@github-actions GitHub Actions
Copy link

TestsPassed ✅Skipped ⚠️Failed
TT-Forge-FE Tests604 ran480 passed124 skipped0 failed
TestResult
No test annotations available

@github-actions GitHub Actions
Copy link

TestsPassed ✅Skipped ⚠️Failed
TT-Forge-FE Tests662 ran525 passed137 skipped0 failed
TestResult
No test annotations available

1 similar comment
@github-actions GitHub Actions
Copy link

TestsPassed ✅Skipped ⚠️Failed
TT-Forge-FE Tests662 ran525 passed137 skipped0 failed
TestResult
No test annotations available

@github-actions GitHub Actions
Copy link

TestsPassed ✅Skipped ⚠️Failed
TT-Forge-FE Tests665 ran527 passed138 skipped0 failed
TestResult
No test annotations available

@github-actions GitHub Actions
Copy link

TestsPassed ✅Skipped ⚠️Failed
TT-Forge-FE Tests607 ran481 passed126 skipped0 failed
TestResult
No test annotations available

1 similar comment
@github-actions GitHub Actions
Copy link

TestsPassed ✅Skipped ⚠️Failed
TT-Forge-FE Tests607 ran481 passed126 skipped0 failed
TestResult
No test annotations available

@github-actions GitHub Actions
Copy link

TestsPassed ✅Skipped ⚠️Failed
TT-Forge-FE Tests665 ran527 passed138 skipped0 failed
TestResult
No test annotations available

@ashokkumarkannan1 ashokkumarkannan1 force-pushed the akannan/repeat_op_support branch 6 times, most recently from 8bc0f60 to fa99c25 Compare February 24, 2025 17:45
@github-actions GitHub Actions
Copy link

TestsPassed ✅Skipped ⚠️Failed
TT-Forge-FE Tests665 ran527 passed138 skipped0 failed
TestResult
No test annotations available

@github-actions GitHub Actions
Copy link

TestsPassed ✅Skipped ⚠️Failed
TT-Forge-FE Tests607 ran481 passed126 skipped0 failed
TestResult
No test annotations available

@github-actions GitHub Actions
Copy link

TestsPassed ✅Skipped ⚠️Failed
TT-Forge-FE Tests665 ran527 passed138 skipped0 failed
TestResult
No test annotations available

@github-actions GitHub Actions
Copy link

TestsPassed ✅Skipped ⚠️Failed
TT-Forge-FE Tests607 ran481 passed126 skipped0 failed
TestResult
No test annotations available

@ashokkumarkannan1 ashokkumarkannan1 force-pushed the akannan/repeat_op_support branch 2 times, most recently from bb7863b to 6923297 Compare February 25, 2025 07:33
@ashokkumarkannan1 ashokkumarkannan1 force-pushed the akannan/repeat_op_support branch from 6923297 to b49d28d Compare February 25, 2025 07:41
@ashokkumarkannan1 ashokkumarkannan1 mentioned this pull request Feb 25, 2025
Closed
@ashokkumarkannan1
Copy link
Contributor Author

Hi @nvukobratTT ,
I have now moved the handling of dimension expansion based repeat dimensions from TVM to Forge-FE itself. Could you please it now and approve this?

@github-actions GitHub Actions
Copy link

TestsPassed ✅Skipped ⚠️Failed
TT-Forge-FE Tests665 ran527 passed138 skipped0 failed
TestResult
No test annotations available

@github-actions GitHub Actions
Copy link

TestsPassed ☑️Skipped ⚠️Failed ❌️
TT-Forge-FE Tests607 ran480 passed126 skipped1 failed
TestResult
TT-Forge-FE Tests
pytest
test_dla.test_dla_pytorch[dla34]❌ failure

@github-actions GitHub Actions
Copy link

TestsPassed ✅Skipped ⚠️Failed
TT-Forge-FE Tests607 ran481 passed126 skipped0 failed
TestResult
No test annotations available

@github-actions GitHub Actions
Copy link

TestsPassed ✅Skipped ⚠️Failed
TT-Forge-FE Tests665 ran527 passed138 skipped0 failed
TestResult
No test annotations available

@github-actions GitHub Actions
Copy link

TestsPassed ✅Skipped ⚠️Failed
TT-Forge-FE Tests607 ran481 passed126 skipped0 failed
TestResult
No test annotations available

nvukobratTT
nvukobratTT approved these changes Feb 26, 2025
View reviewed changes
Copy link
Contributor

@nvukobratTT nvukobratTT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for clarification @ashokkumarkannan1, feel free to merge this change

@ashokkumarkannan1 ashokkumarkannan1 merged commit 33258a7 into main Feb 26, 2025
10 checks passed
@ashokkumarkannan1 ashokkumarkannan1 deleted the akannan/repeat_op_support branch February 26, 2025 14:24
@ashokkumarkannan1 ashokkumarkannan1 self-assigned this Feb 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vkovinicTT vkovinicTT vkovinicTT left review comments

@nvukobratTT nvukobratTT nvukobratTT approved these changes

@pilkicTT pilkicTT Awaiting requested review from pilkicTT pilkicTT is a code owner

@dgolubovicTT dgolubovicTT Awaiting requested review from dgolubovicTT dgolubovicTT is a code owner

Assignees

@ashokkumarkannan1 ashokkumarkannan1

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ashokkumarkannan1 @nvukobratTT @vkovinicTT