Add Llava model bringup #1173
Merged
Add Llava model bringup #1173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
||||||||||||||||||
3 similar comments
|
||||||||||||||||||
|
||||||||||||||||||
|
||||||||||||||||||
ashokkumarkannan1
force-pushed
the
akannan/llava_model_bringup
branch
from
f698620 to
2ce6727
Compare
|
||||||||||||||||||
3 similar comments
|
||||||||||||||||||
|
||||||||||||||||||
|
||||||||||||||||||
ashokkumarkannan1
force-pushed
the
akannan/llava_model_bringup
branch
from
ca89f31 to
b32df62
Compare
ashokkumarkannan1
requested review from
vkovinicTT,
mstojkovicTT,
nvukobratTT,
pilkicTT and
dgolubovicTT
as code owners
|
||||||||||||||
|
||||||||||||||
vkovinicTT
approved these changes
Feb 6, 2025
|
||||||||||||||
nvukobratTT
reviewed
Feb 6, 2025
| return bool(re.match(regex, url)) | ||
|
|
||
|
|
||
| def load_model(variant): |
There was a problem hiding this comment.
Can we keep model loading and Wrapper as part of the test?
Just to be able to see right from the test if we're doing some customizations on the model.
There was a problem hiding this comment.
Sure,. Updated Now.
ashokkumarkannan1
force-pushed
the
akannan/llava_model_bringup
branch
from
b32df62 to
caf9657
Compare
|
||||||||||||||||||
3 similar comments
|
||||||||||||||||||
|
||||||||||||||||||
|
||||||||||||||||||
|
@ashokkumarkannan1 seems like your CI is failing due to imports. Can you check it? |
ashokkumarkannan1
force-pushed
the
akannan/llava_model_bringup
branch
from
caf9657 to
49e939e
Compare
|
||||||||||||||
1 similar comment
|
||||||||||||||
|
||||||||||||||
1 similar comment
|
||||||||||||||
Fixed now. @nvukobratTT |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
Fix #1177
What's changed
Add Model tests for Llava Model
Logs
test_llava.log
Current Issue
And this will be solved in this PR - #1188