Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reshape operator failing rules #1124

Merged
merged 1 commit into from
Feb 20, 2025
Merged

Reshape operator failing rules #1124

merged 1 commit into from
Feb 20, 2025

Conversation

vobojevicTT
Copy link
Contributor

@vobojevicTT vobojevicTT commented Jan 28, 2025 •
edited by vbrkicTT
Loading

Repro commands

Three categories of bugs detected: DATA_MISMATCH, INFERENCE_FAILED and UNSUPPORTED_DIMENSION

To reproduce actual error messages run:

. forge/test/operators/pytorch/test_commands.sh
run_xfail_on

OPERATORS=reshape FAILING_REASONS=INFERENCE_FAILED test_query

Exceptions:

  • RuntimeError: TT_THROW @ /home/vbrkic/src_bgd/ttforge/tt-forge-fe/third_party/tt-mlir/third_party/tt-metal/src/tt-metal/tt_metal/impl/program/program.cpp:840: tt::exception
OPERATORS=reshape FAILING_REASONS=UNSUPPORTED_DIMENSION test_query

Exceptions:

  • tvm.error.InternalError: Traceback (most recent call last):

@vobojevicTT vobojevicTT added the Ops Support new op in tt-forge and tt-mlir label Jan 28, 2025
@vobojevicTT vobojevicTT self-assigned this Jan 28, 2025
@vobojevicTT vobojevicTT changed the title Reshape operator add failing rules Reshape operator - add failing rules Jan 28, 2025
@vobojevicTT vobojevicTT force-pushed the vobojevic/pytorch-reshape-test branch 2 times, most recently from c7987c8 to fd068aa Compare January 28, 2025 09:18
@github-actions GitHub Actions
Copy link

TestsPassed ✅Skipped ⚠️Failed
TT-Forge-FE Tests551 ran476 passed75 skipped0 failed
TestResult
No test annotations available

@vobojevicTT vobojevicTT linked an issue Jan 28, 2025 that may be closed by this pull request
[Failing Rules] Reshape operator #1027
Closed
@github-actions GitHub Actions
Copy link

TestsPassed ✅Skipped ⚠️Failed
TT-Forge-FE Tests493 ran427 passed66 skipped0 failed
TestResult
No test annotations available

@vobojevicTT vobojevicTT force-pushed the vobojevic/pytorch-reshape-test branch 2 times, most recently from 01a0ee9 to e582a76 Compare January 28, 2025 10:08
@github-actions GitHub Actions
Copy link

TestsPassed ✅Skipped ⚠️Failed
TT-Forge-FE Tests551 ran476 passed75 skipped0 failed
TestResult
No test annotations available

@github-actions GitHub Actions
Copy link

TestsPassed ✅Skipped ⚠️Failed
TT-Forge-FE Tests493 ran427 passed66 skipped0 failed
TestResult
No test annotations available

@vobojevicTT vobojevicTT changed the title Reshape operator - add failing rules Reshape operator failing rules Jan 28, 2025
@vobojevicTT vobojevicTT force-pushed the vobojevic/pytorch-reshape-test branch from e582a76 to c918d7e Compare January 28, 2025 10:56
@github-actions GitHub Actions
Copy link

TestsPassed ✅Skipped ⚠️Failed
TT-Forge-FE Tests493 ran427 passed66 skipped0 failed
TestResult
No test annotations available

@github-actions GitHub Actions
Copy link

TestsPassed ✅Skipped ⚠️Failed
TT-Forge-FE Tests551 ran476 passed75 skipped0 failed
TestResult
No test annotations available

@vobojevicTT vobojevicTT marked this pull request as ready for review January 28, 2025 13:34
@vbrkicTT vbrkicTT mentioned this pull request Feb 10, 2025
Draft
1 task
@vobojevicTT vobojevicTT force-pushed the vobojevic/pytorch-reshape-test branch from c918d7e to 96b94dd Compare February 20, 2025 10:40
@vobojevicTT vobojevicTT force-pushed the vobojevic/pytorch-reshape-test branch from 96b94dd to 7d8206a Compare February 20, 2025 10:48
@github-actions GitHub Actions
Copy link

TestsPassed ✅Skipped ⚠️Failed
TT-Forge-FE Tests601 ran480 passed121 skipped0 failed
TestResult
No test annotations available

@github-actions GitHub Actions
Copy link

TestsPassed ✅Skipped ⚠️Failed
TT-Forge-FE Tests660 ran520 passed140 skipped0 failed
TestResult
No test annotations available

@github-actions GitHub Actions
Copy link

TestsPassed ✅Skipped ⚠️Failed
TT-Forge-FE Tests601 ran480 passed121 skipped0 failed
TestResult
No test annotations available

@github-actions GitHub Actions
Copy link

TestsPassed ✅Skipped ⚠️Failed
TT-Forge-FE Tests660 ran520 passed140 skipped0 failed
TestResult
No test annotations available

@vobojevicTT vobojevicTT merged commit 40eb5fd into main Feb 20, 2025
10 checks passed
@vobojevicTT vobojevicTT deleted the vobojevic/pytorch-reshape-test branch February 20, 2025 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vbrkicTT vbrkicTT vbrkicTT left review comments

@nvukobratTT nvukobratTT nvukobratTT approved these changes

@pilkicTT pilkicTT Awaiting requested review from pilkicTT pilkicTT is a code owner

@dgolubovicTT dgolubovicTT Awaiting requested review from dgolubovicTT dgolubovicTT is a code owner

@kmilanovicTT kmilanovicTT Awaiting requested review from kmilanovicTT

Assignees

@vobojevicTT vobojevicTT

Labels
Ops Support new op in tt-forge and tt-mlir
Projects
None yet
Milestone
[FFE - E2E] Op testing (sweeps)
Development

Successfully merging this pull request may close these issues.

[Failing Rules] Reshape operator
3 participants
@vobojevicTT @nvukobratTT @vbrkicTT