Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve test id parsing #1085

Merged
merged 1 commit into from
Jan 23, 2025
Merged

Improve test id parsing #1085

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 18 additions & 7 deletions forge/test/operators/utils/plan.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -621,8 +621,22 @@ def test_id_to_test_vector(cls, test_id: str) -> TestVector:

test_id = test_id.replace("no_device-", "")

# Split by '-' but not by ' -'
parts = re.split(r"(?<! )-", test_id)
# Split by '-' but not by ' -' and not by '(-'
# Explanation: Valid negative numbers can appear in kwargs or shapes or potentially other tuples
# * Space ' ' before '-' is for separating parameters
# Example: reshape-FROM_HOST-{'shape': (8, -1)}-(2, 2, 2, 2)-None-None
# * Open bracket '(' before '-' is for opening tuples
# Example: reshape-FROM_HOST-{'shape': (-1, 15)}-(3, 4, 5)-None-None

# Replace - with |
test_id = test_id.replace("-", "|")
# Replace ' |' with ' -' (revert previous replacement for valid negative numbers)
test_id = test_id.replace(" |", " -")
# Replace '(|' with '(-' (revert previous replacement for valid negative numbers)
test_id = test_id.replace("(|", "(-")

parts = test_id.split("|")

assert len(parts) == 6 or len(parts) == 7, f"Invalid test id: {test_id} / {parts}"
if len(parts) == 6:
dev_data_format_index = 4
Expand All @@ -644,11 +658,8 @@ def test_id_to_test_vector(cls, test_id: str) -> TestVector:
math_fidelity_part = parts[math_fidelity_index]
if math_fidelity_part == "None":
math_fidelity_part = None
# TODO remove hardcoded values here
if math_fidelity_part in (
"HiFi40",
"HiFi41",
):
# As last parameter in test id is math fidelity, in case of duplicated tests numeric suffix should be ignored
if math_fidelity_part is not None and math_fidelity_part.startswith("HiFi4"):
math_fidelity_part = "HiFi4"
math_fidelity = eval(f"forge._C.{math_fidelity_part}") if math_fidelity_part is not None else None

Expand Down
Loading