Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed: add_batch method observer on PyUniformReplayBuffer bug #198 #200

Closed
wants to merge 1 commit into from

Conversation

j0rd1smit
Copy link

Fixes issue #198

@ebrevdo ebrevdo requested a review from nealwu October 23, 2019 16:28
@ebrevdo ebrevdo self-assigned this Oct 23, 2019
@nealwu
Copy link
Contributor

nealwu commented Nov 7, 2019

Hi, this change breaks a test on https://github.com/tensorflow/agents/blob/master/tf_agents/agents/ppo/examples/v1/train_eval.py, specifically because of metric_utils.py, which uses py_driver: https://github.com/tensorflow/agents/blob/master/tf_agents/eval/metric_utils.py#L72.

The error message is

ValueError: Batch size 1 does not match previously set batch size 2. Make sure your batch size is set correctly in BatchedPyMetric initialization and that the batch size remains constant.

@ebrevdo, do you know what the right fix would be?

@tfboyd
Copy link
Member

tfboyd commented Mar 26, 2020

Closing due to time passed. The mismatch between py and tf version of components is confusing; and is being improved slowly based on customer need.

@tfboyd tfboyd closed this Mar 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants