Reserve "__temporal_" prefix #1806
Merged
+99
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, signal, from using __temporal_ prefix. TODO: add tests for activities/workflows, all other scenarios.
cretz
approved these changes
Feb 7, 2025
Quinn-With-Two-Ns
approved these changes
Feb 7, 2025
# Conflicts: # test/integration_test.go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Prevent users from using
__temporal_across workflows, activities, nexus operations/services, and signals.Queries and updates already reserve the
__prefixWhy?
We want to reserve a prefix to throw any special behavior under.
Checklist
Closes Special behavior for Temporal built-in prefixes #1779
How was this tested:
Added tests