Add option to override UI port #1793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sushisource
reviewed
Jan 28, 2025
| @@ -158,6 +161,9 @@ func prepareCommand(options *DevServerOptions, host, port, namespace string) []s | |||
| if options.DBFilename != "" { | |||
| args = append(args, "--db-filename", options.DBFilename) | |||
| } | |||
| if options.UIPort != "" { | |||
| args = append(args, "--ui-port", options.UIPort) | |||
There was a problem hiding this comment.
Does this also enable if not enabled? Docstring should mention that too
There was a problem hiding this comment.
No it does not enable the UI
There was a problem hiding this comment.
I am matching the behaviour of the dev server here
There was a problem hiding this comment.
Well, maybe we should change dev server then because that's non obvious. I'd at least expect it to fail. Silently doing nothing no good
At bare minimum, the option should say it does nothing in that case if we don't change the behavior.
There was a problem hiding this comment.
I think in a lot of cases they are independently set via env vars and you may disable UI without changing port especially in hierarchical config cases like k8s/helm.
cretz
approved these changes
Feb 3, 2025
Quinn-With-Two-Ns
force-pushed
the
issue-1788
branch
2 times, most recently
from
48f2b59 to
2fa452d
Compare
Quinn-With-Two-Ns
force-pushed
the
issue-1788
branch
from
2fa452d to
5e85fd5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add option to override UI port
closes: #1788