Fix a bug with writing history before the history event is created. #5476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitrii-beliakov
requested review from
IvanChupin,
pablomuri,
pkazlenka and
yuliiamir
pkazlenka
approved these changes
Nov 23, 2023
| @@ -55,7 +55,8 @@ public enum Event { | |||
| PARTIAL_UPDATE("HA-Flow partial update"), | |||
| REROUTE("HA-Flow reroute"), | |||
| DELETE("HA-Flow delete"), | |||
| PATH_SWAP("HA-flow path swap"); | |||
| PATH_SWAP("HA-flow path swap"), | |||
There was a problem hiding this comment.
Let's be consistent and use 'HA-Flow' at least within the same enum.
There was a problem hiding this comment.
I corrected the description
|
Fix was tested manually, but needs to pass regression before the merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This issue addresses the problem that some history actions are created before a history event is created and since there is a FK relationship between actions and events, those actions are not saved and the appropriate error is written in the logs.
The simplest reproduction steps are just trying to execute an operation for non-existing flow, then the response contain an error message sating that an operation cannot be executed because the flow was not found. At the same time there is an error in the logs saying that
event_idcannot be null. When we navigate to the history of that flow, we can see that this information is not saved. There could be other use cases, essentially when an error happens before the event is created. Usually, the history event is created after a flow validation action.After this fix, a history event is created before any other actions, so all errors and other actions are saved in the history and there is no error in the logs.
Reproductions steps: for creation, create a flow, then create another flow with the same request, but different flow ID. For other operations execute them with any valid request parameters, but for non-existing flow. Then, navigate to the history of that flow, the history is saved even for non-existing flows.
Affected operations:
Simple flow:
Y-flow:
HA-flow:
(*? reroute was prone to the same error, however I wasn't able to find simple reprosteps)
closes #4738