-
-
Notifications
You must be signed in to change notification settings - Fork 524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New telepresence replace command. #3764
Open
thallgren
wants to merge
61
commits into
release/v2
Choose a base branch
from
thallgren/replace-command
base: release/v2
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Still a draft. Integration and docs are in the works. |
1d01171
to
002afbe
Compare
002afbe
to
b31a69e
Compare
b31a69e
to
e816443
Compare
e816443
to
681a5a0
Compare
681a5a0
to
b4c333f
Compare
074f21b
to
d0d27c8
Compare
d0d27c8
to
215d7ff
Compare
215d7ff
to
198d06a
Compare
The split between the two was for historical reasons. The `intercepts` map was only capable of storing proto-bufs. Since that's no longer the case, those two maps can be merged. Signed-off-by: Thomas Hallgren <[email protected]>
Signed-off-by: Thomas Hallgren <[email protected]>
Also removes the `sessions` map from the traffic-manager's `state` because it has been made redundant. Signed-off-by: Thomas Hallgren <[email protected]>
Signed-off-by: Thomas Hallgren <[email protected]>
Signed-off-by: Thomas Hallgren <[email protected]>
Signed-off-by: Thomas Hallgren <[email protected]>
This build-flag is not enabled by default, but can be used when there is a desire to build a telepresence client that links the fuseftp implementation instead of using a remote process via gRPC. Signed-off-by: Thomas Hallgren <[email protected]>
Signed-off-by: Thomas Hallgren <[email protected]>
Signed-off-by: Thomas Hallgren <[email protected]>
Signed-off-by: Thomas Hallgren <[email protected]>
Signed-off-by: Thomas Hallgren <[email protected]>
Signed-off-by: Thomas Hallgren <[email protected]>
Signed-off-by: Thomas Hallgren <[email protected]>
When reading from a connection and then writing the data on a tunnel, it is essential that any delay when writing also causes the next read from the connection to be delayed. Delaying the connection read causes a back-pressure on the TCP stack, and will make the sender aware that things need to slow down, which is exactly what we want. Closes #3766 Signed-off-by: Thomas Hallgren <[email protected]>
Signed-off-by: Thomas Hallgren <[email protected]>
Signed-off-by: Thomas Hallgren <[email protected]>
Signed-off-by: Thomas Hallgren <[email protected]>
Signed-off-by: Thomas Hallgren <[email protected]>
Signed-off-by: Thomas Hallgren <[email protected]>
Signed-off-by: Thomas Hallgren <[email protected]>
Signed-off-by: Thomas Hallgren <[email protected]>
Introducing `telepresence replace` as an alternative to the `intercept` resulted in a lot of documentation changes. For many (most) use-cases, a `replace` is more natural than an `intercept` unless there's an ability to do personal intercepts, and the OSS edition doesn't provide that. Signed-off-by: Thomas Hallgren <[email protected]>
1ab6cf4
to
311de3e
Compare
Signed-off-by: Thomas Hallgren <[email protected]>
Signed-off-by: Thomas Hallgren <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new
telepresence replace
command simplifies and clarifies container replacement.Previously, the
--replace
flag within thetelepresence intercept
command was used to replace containers. However, this approach introduced inconsistencies and limitations:To address these issues, the
--replace
flag withintelepresence intercept
has been deprecated. The newtelepresence replace
command provides a dedicated and consistent method for replacing containers, enhancing clarity and reliability.Key differences between
replace
andintercept
:replace
command targets and affects an entire container, impacting all its traffic, while anintercept
targets specific services and/or service/container ports.--port
flag are container ports.replace
can occur without intercepting any ports.replace
, the original container is no longer active within the cluster.The deprecated
--replace
flag still works, but is hidden from thetelepresence intercept
command help, and will print a deprecation warning when used.