feat: fix dangaling metrics regading status code #146
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Referes to #133
Changes
The metric
sparrow_latency_duration_seconds
will now be clear before the new duration with label status is exposed.Dangling metrics that do not show the current status are cleared up.
Additionally, I have introduced two new metrics like @puffitos suggested.
sparrow_latency_seconds
sparrow_latency_count
(oldsparrow_latency_count
has been renamed tosparrow_latency_total_count
)For additional information look at the commits.
Tests done
First run:
Second run:
TODO