refactor: use time.After (#41)

telekom · Dec 14, 2023 · 4472a0b · 4472a0b
1 parent 7f408eb
commit 4472a0b
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 8 deletions.
diff --git a/internal/helper/retry.go b/internal/helper/retry.go
@@ -48,13 +48,10 @@ func Retry(effector Effector, rc RetryConfig) func(ctx context.Context) error {
 			delay := getExpBackoff(rc.Delay, r)
 			log.WarnContext(ctx, fmt.Sprintf("Effector call failed, retrying in %v", delay))
 
-			timer := time.NewTimer(delay)
-			defer timer.Stop() //nolint:gocritic //TODO: check if this is correct
-
 			select {
 			case <-ctx.Done():
 				return ctx.Err()
-			case <-timer.C:
+			case <-time.After(delay):
 			}
 		}
 	}

diff --git a/pkg/config/http.go b/pkg/config/http.go
@@ -68,13 +68,10 @@ func (gl *HttpLoader) Run(ctx context.Context) {
 		log.Info("Successfully got remote runtime configuration")
 		gl.cCfgChecks <- runtimeCfg.Checks
 
-		timer := time.NewTimer(gl.cfg.Loader.Interval)
-		defer timer.Stop() //nolint:gocritic // TODO: check if this is right
-
 		select {
 		case <-ctx.Done():
 			return
-		case <-timer.C:
+		case <-time.After(gl.cfg.Loader.Interval):
 		}
 	}
 }