Adding nsupdate DNS challenge #169
Merged
+193
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schurzi
reviewed
Feb 11, 2025
schurzi
reviewed
Feb 12, 2025
| connection: local | ||
| delegate_to: localhost | ||
| vars: | ||
| relevant_domains: "{{ ([acme_domain.zone] + acme_domain.subject_alt_name | default([])) | ansible.builtin.unique }}" |
There was a problem hiding this comment.
I think this needs to change. acme_domain.zone will not be in the generated csr and will not be considered as a valid domain for the certificate. Also this is a difference to the other challenge providers and I'd like to keep the basic logic the same.
What need do you see for doing this?
There was a problem hiding this comment.
Allright, I've changed acme_domain.zone into acme_domain.certificate_name. As one could specify a wildcard here, the *. needs to be replaced in the record (see below). This is also the way how it's done in the other challenge handlers (like autodns.yml).
schurzi
reviewed
Feb 12, 2025
diLLec
force-pushed
the
main
branch
2 times, most recently
from
a55b370 to
bb49e60
Compare
Signed-off-by: Martin Schurz <[email protected]>
Signed-off-by: Martin Schurz <[email protected]>
Signed-off-by: Martin Schurz <[email protected]>
schurzi
reviewed
Feb 14, 2025
Comment on lines
+23
to
+25
| loop_control: | ||
| label: "zone={{ domain }} rr={{ record_name }} (TXT) {{ record_data }}" | ||
| loop_var: "domain" |
There was a problem hiding this comment.
praise: great idea, this makes the log more readable!
schurzi
approved these changes
Feb 14, 2025
schurzi
approved these changes
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey all,
please find attached our implementation for nsupdate to include into the module. I hope that my change covers all the documentation needs that you have here - please tell me if there is anything missing. Anyhow, please give me some feedback on my changes. There also is a test playbook which imports the task out of the role which I can provide if you need it.
Greetings,
Michael