Improved numbits #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
telegraphic
approved these changes
Apr 9, 2024
|
Hey @pravirkr, LGTM (I only skimmed the cpp, but trust you've done a good job!). I haven't been active on this, and you have, so I've added you as a collaborator to give you access for future changes too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @telegraphic, I was comparing and testing pack/unpack utilities in
sigpyprocand made some changes innumbits.I am creating this PR, in case you find this useful.
Changes
bitorderto support both "big" and "little" endian packing/unpacking. This is related to unpack() function deals 1-bit data differently with ewanbarr/sigpyproc FRBs/sigpyproc3#26. I thinksigprocuses different conventions for 1-bit and 2,4-bit unpacking.parallelto use OpenMP.unpack_bufferedandpack_bufferedto support packing/unpacking using a pre-allocated buffer.unpack_lookupto use a lookup table for unpacking bits. No significant performance gain.numpy.